Created attachment 162270 [details] [review] Bug 36130: Fetch all batches for the table Test plan, ktd: - Add 'FreeForm' backend and enable ILLModule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) - Add 21 batches, run the following command in kshell: for x in {1..21}; do echo "INSERT INTO illbatches (name, backend, library_id, status_code, patron_id) VALUES ('$x', 'FreeForm', 'CPL', 'NEW', 52);"; done | koha-mysql kohadev - Visit ILL batches page: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=batch_list - Notice only 20 batches show. - Apply patch. Notice 20 batches show but now there is a page 2 link. - Test page 2 works as expected, delete a batch, notice only 1 page with 20 batches shows again.
Created attachment 162273 [details] [review] Bug 36130: Fetch all batches for the table Test plan, ktd: - Add 'FreeForm' backend and enable ILLModule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) - Add 21 batches, run the following command in kshell: for x in {1..21}; do echo "INSERT INTO illbatches (name, backend, library_id, status_code, patron_id) VALUES ('$x', 'FreeForm', 'CPL', 'NEW', 52);"; done | koha-mysql kohadev - Visit ILL batches page: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=batch_list - Notice only 20 batches show. - Apply patch. Notice 20 batches show but now there is a page 2 link. - Test page 2 works as expected, delete a batch, notice only 1 page with 20 batches shows again. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 162319 [details] [review] Bug 36130: Fetch all batches for the table Test plan, ktd: - Add 'FreeForm' backend and enable ILLModule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) - Add 21 batches, run the following command in kshell: for x in {1..21}; do echo "INSERT INTO illbatches (name, backend, library_id, status_code, patron_id) VALUES ('$x', 'FreeForm', 'CPL', 'NEW', 52);"; done | koha-mysql kohadev - Visit ILL batches page: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=batch_list - Notice only 20 batches show. - Apply patch. Notice 20 batches show but now there is a page 2 link. - Test page 2 works as expected, delete a batch, notice only 1 page with 20 batches shows again. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk>
> - Visit ILL batches page: > <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=batch_list > - Notice only 20 batches show. hmm, I got a mostly empty page with just "new ILL request" and "List requests" Is that the right URL? ↓↓↓↓ http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=batch_list - no server log error - no JS error - illbatches table is populated with 21 rows - services where restarted after setting up ILL - ILL home looks about right (http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl) Any hint of some implicit step that I would have missed?
Created attachment 162810 [details] [review] Bug 36130: Fetch all batches for the table Test plan, ktd: - Add 'FreeForm' backend and enable ILLModule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) - Install a metadata enrichment plugin, e.g.: https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases - Add 21 batches, run the following command in kshell: for x in {1..21}; do echo "INSERT INTO illbatches (name, backend, library_id, status_code, patron_id) VALUES ('$x', 'FreeForm', 'CPL', 'NEW', 52);"; done | koha-mysql kohadev - Visit ILL batches page: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=batch_list - Notice only 20 batches show. - Apply patch. Notice 20 batches show but now there is a page 2 link. - Test page 2 works as expected, delete a batch, notice only 1 page with 20 batches shows again. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk>
(In reply to Victor Grousset/tuxayo from comment #4) > Any hint of some implicit step that I would have missed? Thank you Victor, couple things were happening here: 1) I was missing a step in the test plan (the metadata enrichment plugin step is required) 2) The base ILL batches functionality broke after bug 34478. This current bug now depends on bug 36241 in order to work properly. Thank you.
Pagination works are advertised with this patch. I had to use your data faker script [1] in order to test. But when I scroll down on the page, some weird behavior is trying to scroll up again. Please check. [1] https://github.com/ammopt/koha-ill-dev/blob/master/fake_data.pl
Created attachment 163025 [details] [review] Bug 36130: Fetch all batches for the table Test plan, ktd: - Add 'FreeForm' backend and enable ILLModule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) - Install a metadata enrichment plugin, e.g.: https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases - Add 21 batches, run the following command in kshell: for x in {1..21}; do echo "INSERT INTO illbatches (name, backend, library_id, status_code, patron_id) VALUES ('$x', 'FreeForm', 'CPL', 'NEW', 52);"; done | koha-mysql kohadev - Visit ILL batches page: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=batch_list - Notice only 20 batches show. - Apply patch. Notice 20 batches show but now there is a page 2 link. - Test page 2 works as expected, delete a batch, notice only 1 page with 20 batches shows again. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(In reply to Tomás Cohen Arazi from comment #7) > But when I scroll down on the page, some weird behavior is trying to scroll > up again. Please check. I decided to file a separate bug for that, as it is not introduced by this.
Pushed for 24.05! Well done everyone, thank you!
Depends on Bug 36241 not in 23.11.x
(In reply to Fridolin Somers from comment #11) > Depends on Bug 36241 not in 23.11.x Hey, sorry Frido I added the dependency because at the time I submitted the bug bug 36241 was required to follow the test plan. This actually depends on bug 30719 which is in 23.11.x so this should ideally be backported.
Pushed to 23.11.x for 23.11.04
Missing dependencies for 23.05.x, no backport.