On the staff interface the Status column on members/holdshistory.pl includes the reason for cancellation, if there is one. We should add this to Status column on opac-holdshistory.pl as well.
Created attachment 162309 [details] [review] Bug 36138: Add reason to status column on opac-holdshistory, if there is a reason TO TEST: 1. Turn on OPACHoldsHistory 2. Make some holds for a patron and then cancel them with a reason. 3. Log in as that patron and go to the 'Holds history' tab. Notice the text in the 'Status' column is 'Cancelled' but nothing shows up regarding the reason. 4. Apply patch and try again, this time you should see the reason for cancellation.
Created attachment 162404 [details] [review] Bug 36138: Add reason to status column on opac-holdshistory, if there is a reason TO TEST: 1. Turn on OPACHoldsHistory 2. Make some holds for a patron and then cancel them with a reason. 3. Log in as that patron and go to the 'Holds history' tab. Notice the text in the 'Status' column is 'Cancelled' but nothing shows up regarding the reason. 4. Apply patch and try again, this time you should see the reason for cancellation. Signed-off-by: Esther <esther@bywatersolutions.com>
Created attachment 162425 [details] [review] Bug 36138: Add reason to status column on opac-holdshistory, if there is a reason TO TEST: 1. Turn on OPACHoldsHistory 2. Make some holds for a patron and then cancel them with a reason. 3. Log in as that patron and go to the 'Holds history' tab. Notice the text in the 'Status' column is 'Cancelled' but nothing shows up regarding the reason. 4. Apply patch and try again, this time you should see the reason for cancellation. Signed-off-by: Esther <esther@bywatersolutions.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Pushed as is, but maybe you want to add a span? The status are all wrapped already and it would make it much easier to target this string if required.
Pushed for 24.05! Well done everyone, thank you!
Small nice enhancement, Pushed to 23.11.x for 23.11.06
Enhancement will not be backported to 23.05.x