Bug 36150 - Circulation home page styling does not match Cataloging home page styling
Summary: Circulation home page styling does not match Cataloging home page styling
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Pedro Amorim
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on:
Blocks: 36164
  Show dependency treegraph
 
Reported: 2024-02-22 12:08 UTC by Pedro Amorim
Modified: 2024-03-19 15:23 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the styling of the circulation home page for the staff interface. It is now consistent with the cataloging home page, and includes wider side margins.
Version(s) released in:
24.05.00,23.11.04


Attachments
Bug 36150: Update circulation-home.tt layout (19.73 KB, patch)
2024-02-22 12:10 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 36150: Update circulation-home.tt layout (19.78 KB, patch)
2024-02-23 19:13 UTC, David Nind
Details | Diff | Splinter Review
Bug 36150: Update circulation-home.tt layout (19.84 KB, patch)
2024-02-26 10:08 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2024-02-22 12:08:53 UTC
Compare both:
<staff_url>/cgi-bin/koha/cataloguing/cataloging-home.pl
<staff_url>/cgi-bin/koha/circ/circulation-home.pl

There's no reason for circulation home to differ and not have side margins.
Comment 1 Pedro Amorim 2024-02-22 12:10:26 UTC
Created attachment 162331 [details] [review]
Bug 36150: Update circulation-home.tt layout

Test plan:
Compare both pages:
<staff_url>/cgi-bin/koha/cataloguing/cataloging-home.pl
<staff_url>/cgi-bin/koha/circ/circulation-home.pl

Apply patch
Compare both pages again
Comment 2 Pedro Amorim 2024-02-22 12:11:53 UTC
git show -w <patch_hash>:

@@ -23,9 +23,11 @@
 [% END #/ WRAPPER sub-header.inc %]
 
     <div class="main container-fluid">
+        <div class="row">
+            <div class="col-md-10 col-md-offset-1 col-lg-8 col-lg-offset-2">
+                [% INCLUDE 'messages.inc' %]
 
                 <h1>Circulation</h1>
-                [% INCLUDE 'messages.inc' %]
 
                 <div class="row">
 
@@ -180,5 +182,7 @@
                             </div>
                     </div>
                 </div>
+            </div>
+        </div>
Comment 3 David Nind 2024-02-23 19:13:22 UTC
Created attachment 162399 [details] [review]
Bug 36150: Update circulation-home.tt layout

Test plan:
Compare both pages:
<staff_url>/cgi-bin/koha/cataloguing/cataloging-home.pl
<staff_url>/cgi-bin/koha/circ/circulation-home.pl

Apply patch
Compare both pages again

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2024-02-23 19:13:57 UTC
This is much nicer, and more consistent!
Comment 5 Martin Renvoize 2024-02-26 10:08:25 UTC
Created attachment 162427 [details] [review]
Bug 36150: Update circulation-home.tt layout

Test plan:
Compare both pages:
<staff_url>/cgi-bin/koha/cataloguing/cataloging-home.pl
<staff_url>/cgi-bin/koha/circ/circulation-home.pl

Apply patch
Compare both pages again

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize 2024-02-26 10:09:31 UTC
Great consistency improvement, thanks Pedro.

Passing QA
Comment 7 Katrin Fischer 2024-03-07 14:04:39 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 8 Fridolin Somers 2024-03-11 09:38:17 UTC
Pushed to 23.11.x for 23.11.04
Comment 9 Lucas Gass 2024-03-19 15:23:53 UTC
Does not apply cleanly to 23.05.x, no backport.