Koha comes with leaflet.js 1.0.3 which is quite old. We need a current leaflet for Bug 31652, so we propose to upgrade to the current version 1.9.4
The patch is too big for bugzilla, please find it here: https://github.com/domm/Koha/commit/baa24a31d61e2435dc287c0f39646cf7dc2ad49e Bug 36151: Update leaflet.js Koha currently comes with leaflet.js 1.0.3 which is quite old (2017). For GeoSearch (Bug 31652) we need a more current leaflet.js, so this patch updates leaflet.js to the current version 1.9.4 Test plan: * Go to staff /cgi-bin/koha/admin/usage_statistics.pl where you see a map and can set the location of the library by clicking on the map. * Apply the patch * Again, go to staff /cgi-bin/koha/admin/usage_statistics.pl * Do a complete reload of the page * It should still work: * Display the location as a pin * Set a new location There was no code change necessary besides downloading the current version of leaflet.js Sponsored-by: Geosphere Austria
(In reply to Thomas Klausner from comment #1) > There was no code change necessary besides downloading the current > version of leaflet.js The about page will need an update to change the number where it says "Leaflet JavaScript library v1.0.3." I have tried where possible to link the license information for that particular release, e.g. https://github.com/Leaflet/Leaflet/blob/v1.9.4/LICENSE, since it's possible licenses could change.
New patch including an update About-page (new version, link to current LICENSE) is available here: https://github.com/domm/Koha/commit/dfa518981fd8327e4ec07ad726496267018b140b Bug 36151: Update leaflet.js Koha currently comes with leaflet.js 1.0.3 which is quite old (2017). For GeoSearch (Bug 31652) we need a more current leaflet.js, so this patch updates leaflet.js to the current version 1.9.4 Test plan: * Go to staff /cgi-bin/koha/admin/usage_statistics.pl where you see a map and can set the location of the library by clicking on the map. * Apply the patch * Again, go to staff /cgi-bin/koha/admin/usage_statistics.pl * Do a complete reload of the page * It should still work: * Display the location as a pin * Set a new location There was no code change necessary besides downloading the current version of leaflet.js and updating the about-page Sponsored-by: Geosphere Austria
This works without issue, signing off.
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
The about.tt change needs a rebase after bug 32693
I notice that this uses: Sponsored-by: Geosphere Austria But bug 31652 uses: Geosphere - https://www.geosphere.at/ This will require mappings to make it look nice in Release notes. Please stick to one spelling :)
Hm, I rebased this, it's quite easy: just kick out the changes in about .pl and re-do them: it's just changing the version number. But of course it's still too large for bugzilla and I currently have no public repo I can push it to and not sure I should use our main repository for this ;) Could someone else take over here?
(In reply to Katrin Fischer from comment #8) > Could someone else take over here? https://gitlab.com/koha-dev/koha-dev/-/commits/bug_36151
Thanks Owen!
Branch with SO's pushed to https://gitlab.com/mrenvoize/Koha/-/commits/bug_36151 All passing QA scripts, works as intended with no regressions I can see. Restored authorship to Thomas. Passing QA
Pushed for 24.05! Well done everyone, thank you!
Not backported to 23.11.06
Module(?) change, nothing to add/edit in the Koha manual.