Created attachment 162385 [details] Dropdown formatting differences When using the feature added by bug 34136, the new "Run with template" dropdown has btn classes on the links in the dropdown list which gives it odd formatting compared to the rest of the dropdowns in the toolbar. I attached a screenshot to hopefully better illustrate. To replicate: - Create a notice with the module of "Reports" -- add something to the "Print" section. Example from the other bug: [% FOREACH b IN data %] <div class="panel panel-default"> <div class="panel-heading">[% b.surname %], [% b.firstname %]</div> <div class="panel-body">Expiration: [% b.dateexpiry %]</div> <div class="panel-footer">ID: [% b.borrowernumber %]</div> </div> [% END %] - Create and run a saved report. Example from the other bug: SELECT * FROM borrowers - Click on the "Run with template" dropdown and hover the template title.
Created attachment 162391 [details] [review] Bug 36157: Remove class from anchor link
Getting sha1 error when trying to apply the patch: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36157: Remove class from anchor link error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc). error: could not build fake ancestor Patch failed at 0001 Bug 36157: Remove class from anchor link hint: Use 'git am --show-current-patch=diff' to see the failed patch Also, shouldn't the commit message be formatted according to the guidelines? (https://wiki.koha-community.org/wiki/Commit_messages)
Created attachment 162422 [details] [review] Bug 36157: Remove class from anchor link Test plan: - Create a notice with the module of "Reports" -- add something to the "Print" section. Example from bug 34136: [% FOREACH b IN data %] <div class="panel panel-default"> <div class="panel-heading">[% b.surname %], [% b.firstname %]</div> <div class="panel-body">Expiration: [% b.dateexpiry %]</div> <div class="panel-footer">ID: [% b.borrowernumber %]</div> </div> [% END %] - Create and run a saved report. Example from the other bug: SELECT * FROM borrowers - Click on the "Run with template" dropdown and hover the template title. - Notice it the styling of the hover. Apply patch. Repeat.
Created attachment 162429 [details] [review] Bug 36157: Remove class from anchor link Test plan: - Create a notice with the module of "Reports" -- add something to the "Print" section. Example from bug 34136: [% FOREACH b IN data %] <div class="panel panel-default"> <div class="panel-heading">[% b.surname %], [% b.firstname %]</div> <div class="panel-body">Expiration: [% b.dateexpiry %]</div> <div class="panel-footer">ID: [% b.borrowernumber %]</div> </div> [% END %] - Create and run a saved report. Example from the other bug: SELECT * FROM borrowers - Click on the "Run with template" dropdown and hover the template title. - Notice it the styling of the hover. Apply patch. Repeat. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 162582 [details] [review] Bug 36157: Remove class from anchor link Test plan: - Create a notice with the module of "Reports" -- add something to the "Print" section. Example from bug 34136: [% FOREACH b IN data %] <div class="panel panel-default"> <div class="panel-heading">[% b.surname %], [% b.firstname %]</div> <div class="panel-body">Expiration: [% b.dateexpiry %]</div> <div class="panel-footer">ID: [% b.borrowernumber %]</div> </div> [% END %] - Create and run a saved report. Example from the other bug: SELECT * FROM borrowers - Click on the "Run with template" dropdown and hover the template title. - Notice it the styling of the hover. Apply patch. Repeat. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.04
Missing 23.05.x dependencies, no backport.