When placing a hold, if you click on a letter to find the patrons whose last name starts with that letter, it shows all patrons. To recreate: 1. In the staff interface, search for a record 2. Click Place hold 3. Click on a letter under the patron search bar (I used H) --> Patrons with last name starting with another letter are displayed
I tried in 23.11 and it's fine. I bisected and found it was due to bug 35329, specifically Bug 35329: Move patron search to modal - funds.
Created attachment 162861 [details] [review] Bug 36251: (bug 35329 follow-up) Fix patron search by first letter when placing a hold Most of the patrons searches open in a modal. Except: * the main one (members-home) * when placing a hold * when requesting an article (did I miss one?) The patron-search.inc BLOCKs need a parent block to know where to locate the elements (form, table, etc), because we can have several patron searches on the same page. Bug 35329 reused '#searchresults': 10 [% SET search_results_block_id = 'searchresults' %] which is used on the main patron search. The ones in the modal are correctly handled: we build the parent node in the "patron_search_modal" block. But for the 2 others the parent block id is wrong. On reserve/request.tt we have one already, so we set the TT variable from the .tt file On circ/request-article we don't have one already, so we can reuse searchresults (could be more specific however to include 'patrons'...) Test plan: Browse patrons by first letter when placing a hold and requesting an article
Created attachment 162906 [details] [review] Bug 36251: (bug 35329 follow-up) Fix patron search by first letter when placing a hold Most of the patrons searches open in a modal. Except: * the main one (members-home) * when placing a hold * when requesting an article (did I miss one?) The patron-search.inc BLOCKs need a parent block to know where to locate the elements (form, table, etc), because we can have several patron searches on the same page. Bug 35329 reused '#searchresults': 10 [% SET search_results_block_id = 'searchresults' %] which is used on the main patron search. The ones in the modal are correctly handled: we build the parent node in the "patron_search_modal" block. But for the 2 others the parent block id is wrong. On reserve/request.tt we have one already, so we set the TT variable from the .tt file On circ/request-article we don't have one already, so we can reuse searchresults (could be more specific however to include 'patrons'...) Test plan: Browse patrons by first letter when placing a hold and requesting an article Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Thanks Jonathan! Testing note: to test article requests, must enable ArticleRequests syspref. 1. Enable ArticleRequests system preference 2. In the staff interface, search for a record 3. Click Place hold 4. Click on a letter under the patron search bar (I used H) --> Should limit to patrons whose last name start with the letter 5. Go back to the record 6. Click Request Article 7. Click on a letter under the patron search bar (I used H) --> Should limit to patrons whose last name start with the letter
*** Bug 36284 has been marked as a duplicate of this bug. ***
Created attachment 163038 [details] [review] Bug 36251: (bug 35329 follow-up) Fix patron search by first letter when placing a hold Most of the patrons searches open in a modal. Except: * the main one (members-home) * when placing a hold * when requesting an article (did I miss one?) The patron-search.inc BLOCKs need a parent block to know where to locate the elements (form, table, etc), because we can have several patron searches on the same page. Bug 35329 reused '#searchresults': 10 [% SET search_results_block_id = 'searchresults' %] which is used on the main patron search. The ones in the modal are correctly handled: we build the parent node in the "patron_search_modal" block. But for the 2 others the parent block id is wrong. On reserve/request.tt we have one already, so we set the TT variable from the .tt file On circ/request-article we don't have one already, so we can reuse searchresults (could be more specific however to include 'patrons'...) Test plan: Browse patrons by first letter when placing a hold and requesting an article Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed for 24.05! Well done everyone, thank you!
Depends on bug 35329 not in 23.11.x