Bug 36292 - 'See all charges' hyperlink to view guarantee fees is not linked correctly
Summary: 'See all charges' hyperlink to view guarantee fees is not linked correctly
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Laura Escamilla
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 33528
Blocks:
  Show dependency treegraph
 
Reported: 2024-03-11 14:39 UTC by Laura Escamilla
Modified: 2024-03-19 21:45 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.04,23.05.10


Attachments
Bug 36292: Fixed 'See all charges' hyperlink for guarantees/guarantor linked charges To test: 1. Add a guarantee / guarantor relationship for two patrons. 2. Add a manual fee to the guarantees' account. 3. Go to the guarantor's account and view the 'Detai (2.11 KB, patch)
2024-03-11 14:46 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 36292: Fixed 'See all charges' hyperlink for guarantees/guarantor linked charges To test: 1. Add a guarantee / guarantor relationship for two patrons. 2. Add a manual fee to the guarantees' account. 3. Go to the guarantor's account and view the 'Detai (2.11 KB, patch)
2024-03-11 14:57 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 36292: Fixed 'See all charges' hyperlink for guarantees/guarantor linked charges (2.21 KB, patch)
2024-03-11 15:01 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 36292: Fixed 'See all charges' hyperlink for guarantees/guarantor linked charges (2.26 KB, patch)
2024-03-11 23:07 UTC, David Nind
Details | Diff | Splinter Review
Bug 36292: Fixed 'See all charges' hyperlink for guarantees/guarantor linked charges (2.35 KB, patch)
2024-03-15 08:50 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Laura Escamilla 2024-03-11 14:39:00 UTC
To recreate:
1. Add a guarantee / guarantor relationship for two patrons. 
2. Add a manual fee to the guarantees' account.
3. Go to the guarantor's account and view the 'Details' tab. Under contact information there should be a Guarantees section. There you will see the charges for your guarantee. Click on "See all charges". The link leads you no where.
Comment 1 Laura Escamilla 2024-03-11 14:46:06 UTC Comment hidden (obsolete)
Comment 2 Laura Escamilla 2024-03-11 14:57:57 UTC Comment hidden (obsolete)
Comment 3 Laura Escamilla 2024-03-11 15:01:57 UTC
Created attachment 163046 [details] [review]
Bug 36292: Fixed 'See all charges' hyperlink for guarantees/guarantor linked charges

To test:
1. Add a guarantee / guarantor relationship for two patrons.
2. Add a manual fee to the guarantees' account.
3. Go to the guarantor's account and view the 'Details' tab. Under contact information there should be a Guarantees section. There you will see the charges for your guarantee. Click on ‘See all charges’. The link leads you no where.
4. Apply the patch and restart_all
5. Refresh the guarantor’s page and click on ‘See all charges’ again. This time it will take you down to the ‘Guarantees’ Charges’ panel.
6. Sign off and have a great day! :D
Comment 4 David Nind 2024-03-11 23:07:07 UTC
Created attachment 163065 [details] [review]
Bug 36292: Fixed 'See all charges' hyperlink for guarantees/guarantor linked charges

To test:
1. Add a guarantee / guarantor relationship for two patrons.
2. Add a manual fee to the guarantees' account.
3. Go to the guarantor's account and view the 'Details' tab. Under contact information there should be a Guarantees section. There you will see the charges for your guarantee. Click on ‘See all charges’. The link leads you no where.
4. Apply the patch and restart_all
5. Refresh the guarantor’s page and click on ‘See all charges’ again. This time it will take you down to the ‘Guarantees’ Charges’ panel.
6. Sign off and have a great day! :D

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Marcel de Rooy 2024-03-15 08:50:47 UTC
Created attachment 163174 [details] [review]
Bug 36292: Fixed 'See all charges' hyperlink for guarantees/guarantor linked charges

To test:
1. Add a guarantee / guarantor relationship for two patrons.
2. Add a manual fee to the guarantees' account.
3. Go to the guarantor's account and view the 'Details' tab. Under contact information there should be a Guarantees section. There you will see the charges for your guarantee. Click on ‘See all charges’. The link leads you no where.
4. Apply the patch and restart_all
5. Refresh the guarantor’s page and click on ‘See all charges’ again. This time it will take you down to the ‘Guarantees’ Charges’ panel.
6. Sign off and have a great day! :D

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Katrin Fischer 2024-03-15 14:40:29 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-03-18 09:18:27 UTC
Pushed to 23.11.x for 23.11.04
Comment 8 Fridolin Somers 2024-03-18 09:19:42 UTC
Depends on use of new tabs Bug 33528
Comment 9 Lucas Gass 2024-03-19 21:45:47 UTC
Backported to 23.05.x for upcoming 23.05.10