Bug 36379 - Authorities search is broken
Summary: Authorities search is broken
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Phil Ringnalda
QA Contact: Julian Maurice
URL:
Keywords:
Depends on:
Blocks: 36192
  Show dependency tree / graph
 
Reported: 2024-03-20 21:10 UTC by Emily Lamancusa (emlam)
Modified: 2024-04-17 15:21 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Circulation function:

Attachments
Bug 36379: Fix auth_finder.pl to not expect the op cud-do_search (1.70 KB, patch)
2024-04-04 23:36 UTC, Phil Ringnalda 		Details | Diff | Splinter Review
Bug 36379: Fix auth_finder.pl to not expect the op cud-do_search (1.75 KB, patch)
2024-04-05 10:15 UTC, David Nind 		Details | Diff | Splinter Review
Bug 36379: Fix auth_finder.pl to not expect the op cud-do_search (1.81 KB, patch)
2024-04-08 08:22 UTC, Julian Maurice 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emily Lamancusa (emlam) 2024-03-20 21:10:58 UTC 
In KTD:
1. Go to a biblio record
2. Click Edit > Edit Record
3. Pick a field with an authority link (e.g. 100$a) and click the tag editor button to open an authority search popup
4. Enter some search terms and click "Search"
5. Nothing happens
Comment 1 Phil Ringnalda 2024-04-04 23:27:57 UTC 
authorities/auth_finder.pl thinks the op is cud-do_search; koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc thinks the op is do_search and is correct, since the method is GET.
Comment 2 Phil Ringnalda 2024-04-04 23:36:05 UTC 
Created attachment 164442 [details] [review]
Bug 36379: Fix auth_finder.pl to not expect the op cud-do_search

The authority finder just does a GET for a list of search results, it
doesn't create or update or delete, so the template that thinks the op
is do_search is correct.

Test plan:
1. Cataloging - New record
2. In the 1 tab click the Tag editor icon at the end of 100 subfield a
3. In the popup, click Search, and nothing happens, no results are shown.
4. Apply patch, reset_all
5. Repeat steps 1-3, see that you get results.
Comment 3 David Nind 2024-04-05 10:15:37 UTC 
Created attachment 164464 [details] [review]
Bug 36379: Fix auth_finder.pl to not expect the op cud-do_search

The authority finder just does a GET for a list of search results, it
doesn't create or update or delete, so the template that thinks the op
is do_search is correct.

Test plan:
1. Cataloging - New record
2. In the 1 tab click the Tag editor icon at the end of 100 subfield a
3. In the popup, click Search, and nothing happens, no results are shown.
4. Apply patch, reset_all
5. Repeat steps 1-3, see that you get results.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Julian Maurice 2024-04-08 08:22:54 UTC 
Created attachment 164494 [details] [review]
Bug 36379: Fix auth_finder.pl to not expect the op cud-do_search

The authority finder just does a GET for a list of search results, it
doesn't create or update or delete, so the template that thinks the op
is do_search is correct.

Test plan:
1. Cataloging - New record
2. In the 1 tab click the Tag editor icon at the end of 100 subfield a
3. In the popup, click Search, and nothing happens, no results are shown.
4. Apply patch, reset_all
5. Repeat steps 1-3, see that you get results.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 5 Julian Maurice 2024-04-08 08:24:07 UTC 
Works as described, passes QA tests
Comment 6 Katrin Fischer 2024-04-08 13:42:52 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-04-17 15:21:51 UTC 
Depends on Bug 34478 not in 23.11.x