Hello :) When you want to run a report based on borrowers, you can select filters (branchcode, categorycode, etc.). The table works well, but it should be preceded by a summary to help you remember the filters used. But the filter value is missing.
Created attachment 163590 [details] [review] Bug 36380 : Add filter value on patron statistics report summary Test plan: 1) Go to reports and select "Patrons" 2) Select some filters (patron category, library,..) and run it 3) Normally you will see filters selected but with blank value like "branch code = " 4) Apply this patch 5) Refresh Sponsored by: BibLibre
Created attachment 163783 [details] [review] Bug 36380 : Add filter value on patron statistics report summary Test plan: 1) Go to reports and select "Patrons" 2) Select some filters (patron category, library,..) and run it 3) Normally you will see filters selected but with blank value like "branch code = " 4) Apply this patch 5) Refresh Sponsored by: BibLibre Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Please run QA tools - it should note that there should not a space in the commit message between colon and number :)
Created attachment 163883 [details] [review] Bug 36380: Add filter value on patron statistics report summary Test plan: 1) Go to reports and select "Patrons" 2) Select some filters (patron category, library,..) and run it 3) Normally you will see filters selected but with blank value like "branch code = " 4) Apply this patch 5) Refresh Sponsored by: BibLibre
(In reply to Katrin Fischer from comment #3) > Please run QA tools - it should note that there should not a space in the > commit message between colon and number :) Thanks Katrin for your feedback, this is fixed :)
Created attachment 166470 [details] [review] Bug 36380: Add filter value on patron statistics report summary Test plan: 1) Go to reports and select "Patrons" 2) Select some filters (patron category, library,..) and run it 3) Normally you will see filters selected but with blank value like "branch code = " 4) Apply this patch 5) Refresh Sponsored by: BibLibre Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Nice fix! Passing QA
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Enhancement will not be included in 23.05.x