As identified in Bug 35457 (see comment number 7), the SerialsDefaultEMailAddress and AcquisitionsDefaultEMailAddress system preference names have a capital m. Other system preference that include 'Email' as part of their name don't have a capital m (such as KohaAdminEmailAddress - search for 'Email' in system preferences to find all occurrences). The system preference names should be changed for consistency: - SerialsDefaultEMailAddress --> SerialsDefaultEmailAddress - AcquisitionsDefaultEMailAddress --> AcquisitionsDefaultEmailAddress
Created attachment 164008 [details] [review] Bug 36409: Dbrev for existing installations Dbrev to change EMail to Email for SerialsDefaultEMailAddress and AcquisitionsDefaultEMailAddress
Created attachment 164009 [details] [review] Bug 36409: Fix capitalization for AcquisitionsDefaultEMailAddress and SerialsDefaultEMailAddress Replace all instances in files with correct capitalization for the sysprefs: SerialsDefaultEMailAddress AcquisitionsDefaultEMailAddress Test plan: 1. Apply patch 2. Run database update 3. Go to Administration > System Preferences > Acquisitions -> Confirm correct capitalization for AcquisitionsDefaultEmailAddress (should be "Email", not "EMail") 4. Go to Administration > System Preferences > Serials -> Confirm correct capitalization for SerialsDefaultEmailAddress (should be "Email", not "EMail") 5. Use git grep to confirm no remaining instances of "EMail" in the code (other than the new dbrev, original dbrev and original release notes) e.g. git grep --files-with-matches "EMail" 6. Confirm the test plan for Bug 20755 still works
Created attachment 164013 [details] [review] Bug 36409: Dbrev for existing installations Dbrev to change EMail to Email for SerialsDefaultEMailAddress and AcquisitionsDefaultEMailAddress Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 164014 [details] [review] Bug 36409: Fix capitalization for AcquisitionsDefaultEMailAddress and SerialsDefaultEMailAddress Replace all instances in files with correct capitalization for the sysprefs: SerialsDefaultEMailAddress AcquisitionsDefaultEMailAddress Test plan: 1. Apply patch 2. Run database update 3. Go to Administration > System Preferences > Acquisitions -> Confirm correct capitalization for AcquisitionsDefaultEmailAddress (should be "Email", not "EMail") 4. Go to Administration > System Preferences > Serials -> Confirm correct capitalization for SerialsDefaultEmailAddress (should be "Email", not "EMail") 5. Use git grep to confirm no remaining instances of "EMail" in the code (other than the new dbrev, original dbrev and original release notes) e.g. git grep --files-with-matches "EMail" 6. Confirm the test plan for Bug 20755 still works Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 164188 [details] [review] Bug 36409: Dbrev for existing installations Dbrev to change EMail to Email for SerialsDefaultEMailAddress and AcquisitionsDefaultEMailAddress Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 164189 [details] [review] Bug 36409: Fix capitalization for AcquisitionsDefaultEMailAddress and SerialsDefaultEMailAddress Replace all instances in files with correct capitalization for the sysprefs: SerialsDefaultEMailAddress AcquisitionsDefaultEMailAddress Test plan: 1. Apply patch 2. Run database update 3. Go to Administration > System Preferences > Acquisitions -> Confirm correct capitalization for AcquisitionsDefaultEmailAddress (should be "Email", not "EMail") 4. Go to Administration > System Preferences > Serials -> Confirm correct capitalization for SerialsDefaultEmailAddress (should be "Email", not "EMail") 5. Use git grep to confirm no remaining instances of "EMail" in the code (other than the new dbrev, original dbrev and original release notes) e.g. git grep --files-with-matches "EMail" 6. Confirm the test plan for Bug 20755 still works Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Missing 23.05.x dependencies, no backport.