To reproduce: 1) Install FreeForm and enable ILLModule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Checkout to branch b_36243 cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout b_36243 3) Enable CirculateILL sys pref 4) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set "type" = Book and enter '42' on the cardnumber input, click "Create" 6) On the top toolbar, click "Confirm" and confirm the following screen. 7) You now have a new option "Check out" on the toolbar. Click on it. Notice it explodes.
Created attachment 163802 [details] [review] Bug 36416: Fix cud-check_out 1) Install FreeForm and enable ILLModule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Checkout to branch b_36243 cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout b_36243 3) Enable CirculateILL sys pref 4) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set "type" = Book and enter '42' on the cardnumber input, click "Create" 6) On the top toolbar, click "Confirm" and confirm the following screen. 7) You now have a new option "Check out" on the toolbar. Click on it. Notice it explodes. 8) Apply patch. Repeat.
Created attachment 164375 [details] [review] Bug 36416: Fix cud-check_out 1) Install FreeForm and enable ILLModule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Checkout to branch b_36243 cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout b_36243 3) Enable CirculateILL sys pref 4) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set "type" = Book and enter '42' on the cardnumber input, click "Create" 6) On the top toolbar, click "Confirm" and confirm the following screen. 7) You now have a new option "Check out" on the toolbar. Click on it. Notice it explodes. 8) Apply patch. Repeat. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 164678 [details] [review] Bug 36416: Fix cud-check_out 1) Install FreeForm and enable ILLModule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Checkout to branch b_36243 cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout b_36243 3) Enable CirculateILL sys pref 4) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set "type" = Book and enter '42' on the cardnumber input, click "Create" 6) On the top toolbar, click "Confirm" and confirm the following screen. 7) You now have a new option "Check out" on the toolbar. Click on it. Notice it explodes. 8) Apply patch. Repeat. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial clear patch, upgrading Davids signoff to a PQA
Pushed for 24.05! Well done everyone, thank you!
23.11.x not impacted