Bug 36451 - Parenthesis removed from biblio's title in notice
Summary: Parenthesis removed from biblio's title in notice
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-28 08:42 UTC by Jonathan Druart
Modified: 2024-03-29 22:48 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-03-28 08:42:09 UTC
If the last character of a biblio's title is a parenthesis it won't be displayed in the notices.

This is because we are adding the Remove_MARC_punctuation to all biblio and biblioitem fields to notice templates before generating the notice (in add_tt_filters).

Initially added by 
  commit 599887a1855349de6bafe9c1b6ce155ed9be5fb5
  Date:   Tue Feb 16 10:56:02 2010 -0500
  Bugfix: [1/3] overdue_notices.pl does not process all advertised fields

Then propagated...

What was its original need? No idea!
Comment 1 Frédéric Demians 2024-03-28 15:58:54 UTC
> What was its original need? No idea!

But who knows :-) ? After all, it comes from your patch on bug 19578...

It's more archeology than IT. You isolated in C4::Letters:

$val =~ s/\p{P}$// if $val && $table=~/biblio/;

Which itself come from bug 9886.

Removing trailing ponctuation characters in biblio.title could make sense in MARC21 catalog, but not in UNIMARC. In MARC21, ISBD cataloging rules prescribe to add a ponctuation if you have subtitle: $aPrivate eyeballs :$ba golden treasury of bad taste. So biblio.title end with ' :'. It's not the case in UNIMARC. Furthermore, now that we have biblio.subtitle, even in MARC21 removing trailing ponctuation may be an issue.

There may be several options:

1) Suppress any trailing ponctuation character curation.
2) Remove ponctuation less aggressively, just :,;. for example.
Comment 2 Jonathan Druart 2024-03-28 16:08:54 UTC
Yes, I went all the archeological work this morning as well. Hence the "then propagated". It's not "coming from" bug 19578, I only restore (what I thought was) a broken behaviour.

Still no idea what's best here. Needs might differ I guess...
Comment 3 Katrin Fischer 2024-03-29 22:48:36 UTC
It feels odd that we remove ), I think removing other characters makes more sense that are used as standalone ISBD punctuation. I feel this is still handy for MARC21, but maybe we could make it optional as a custom TT filter when using TT in notices going forward?