Bug 36432 is missing some tests for Koha::DateTime::Format::SQL. Since it is already Passed QA, I will attach them in this new bug report.
Created attachment 164235 [details] [review] Bug 36486: Add tests for Koha::DateTime::Format::SQL
Created attachment 166452 [details] [review] Bug 36486: Add tests for Koha::DateTime::Format::SQL Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
FAIL t/Koha/DateTime/Format/SQL.t FAIL file permissions File must have the exec flag WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 27)
Created attachment 166508 [details] [review] Bug 36486: Fix file perms and tidiness
Created attachment 166511 [details] [review] Bug 36486: Add tests for Koha::DateTime::Format::SQL Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 166512 [details] [review] Bug 36486: Fix file perms and tidiness Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
I am never saying no to more tests :)
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Enhancement will not be included in 23.05.x