Bug 36486 - Add tests for Koha::DateTime::Format::SQL
Summary: Add tests for Koha::DateTime::Format::SQL
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on: 36432
Blocks:
  Show dependency treegraph
 
Reported: 2024-04-02 07:33 UTC by Julian Maurice
Modified: 2024-05-30 19:06 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06
Circulation function:


Attachments
Bug 36486: Add tests for Koha::DateTime::Format::SQL (2.89 KB, patch)
2024-04-02 07:35 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 36486: Add tests for Koha::DateTime::Format::SQL (2.97 KB, patch)
2024-05-09 10:40 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 36486: Fix file perms and tidiness (3.55 KB, patch)
2024-05-10 08:31 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 36486: Add tests for Koha::DateTime::Format::SQL (3.05 KB, patch)
2024-05-10 08:45 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 36486: Fix file perms and tidiness (3.65 KB, patch)
2024-05-10 08:45 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2024-04-02 07:33:57 UTC
Bug 36432 is missing some tests for Koha::DateTime::Format::SQL.
Since it is already Passed QA, I will attach them in this new bug report.
Comment 1 Julian Maurice 2024-04-02 07:35:14 UTC
Created attachment 164235 [details] [review]
Bug 36486: Add tests for Koha::DateTime::Format::SQL
Comment 2 Matt Blenkinsop 2024-05-09 10:40:20 UTC
Created attachment 166452 [details] [review]
Bug 36486: Add tests for Koha::DateTime::Format::SQL

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 3 Marcel de Rooy 2024-05-10 08:19:40 UTC
 FAIL   t/Koha/DateTime/Format/SQL.t
   FAIL   file permissions
                File must have the exec flag
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 0, now: 27)
Comment 4 Julian Maurice 2024-05-10 08:31:18 UTC
Created attachment 166508 [details] [review]
Bug 36486: Fix file perms and tidiness
Comment 5 Marcel de Rooy 2024-05-10 08:45:01 UTC
Created attachment 166511 [details] [review]
Bug 36486: Add tests for Koha::DateTime::Format::SQL

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Marcel de Rooy 2024-05-10 08:45:03 UTC
Created attachment 166512 [details] [review]
Bug 36486: Fix file perms and tidiness

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Katrin Fischer 2024-05-10 13:32:34 UTC
I am never saying no to more tests :)
Comment 8 Katrin Fischer 2024-05-10 14:47:08 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 9 Fridolin Somers 2024-05-29 09:00:48 UTC
Pushed to 23.11.x for 23.11.06
Comment 10 Lucas Gass (lukeg) 2024-05-30 19:06:45 UTC
Enhancement will not be included in 23.05.x