Bug 35850 changed the markup of the header search forms but didn't update the JS in staff-global.js to match those changes.
Created attachment 164265 [details] [review] Bug 36490: Correct tab-switching keyboard shortcut for header search forms This patch updates staff-global.js so that we correctly define the keyboard shortcuts for search header tabs following the switch to using the WRAPPER for tabs in Bug 35850. To test, apply the patch clear your browser cache if necessary. - Go to the staff interface. - Test each keyboard shortcut to confirm that the header search tabs activate correctly: - Check in: Alt-r - Renew: Alt-w - Search: Alt-q - Check out: Alt-u - Test that the keyboard shortcut takes you to the correct page if the header search form doesn't exist on the page, e.g. the Authorities home page.
This works except for one small thing. The alt-u shortcut for checkout only works if my cursor is not in the search box. If my cursor is in the search box and waiting for me to type, alt-u inputs a "¨". If my cursor if not in the box, alt-u correctly takes me to checkout. Otherwise all of these work, regardless of where my cursor is. I'm on a Mac, if that matters. So I was pressing Option instead of Alt.
(In reply to Andrew Fuerste-Henry from comment #2) > This works except for one small thing. The alt-u shortcut for checkout only > works if my cursor is not in the search box. I think this is the same as before the patch. Could you check in a pre-Bug 35850 installation, e.g. https://intranet.bywatersolutions.com/ ?
Created attachment 164300 [details] [review] Bug 36490: Correct tab-switching keyboard shortcut for header search forms This patch updates staff-global.js so that we correctly define the keyboard shortcuts for search header tabs following the switch to using the WRAPPER for tabs in Bug 35850. To test, apply the patch clear your browser cache if necessary. - Go to the staff interface. - Test each keyboard shortcut to confirm that the header search tabs activate correctly: - Check in: Alt-r - Renew: Alt-w - Search: Alt-q - Check out: Alt-u - Test that the keyboard shortcut takes you to the correct page if the header search form doesn't exist on the page, e.g. the Authorities home page. Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
(In reply to Owen Leonard from comment #3) > (In reply to Andrew Fuerste-Henry from comment #2) > > This works except for one small thing. The alt-u shortcut for checkout only > > works if my cursor is not in the search box. > > I think this is the same as before the patch. Could you check in a pre-Bug > 35850 installation, e.g. https://intranet.bywatersolutions.com/ ? Confirmed this issue exists before your patch when using Chrome on Mac. As such, I've signed off.
Sorry Owen, this one no longer applies.
Created attachment 165008 [details] [review] Bug 36490: Correct tab-switching keyboard shortcut for header search forms This patch updates staff-global.js so that we correctly define the keyboard shortcuts for search header tabs following the switch to using the WRAPPER for tabs in Bug 35850. To test, apply the patch clear your browser cache if necessary. - Go to the staff interface. - Test each keyboard shortcut to confirm that the header search tabs activate correctly: - Check in: Alt-r - Renew: Alt-w - Search: Alt-q - Check out: Alt-u - Test that the keyboard shortcut takes you to the correct page if the header search form doesn't exist on the page, e.g. the Authorities home page. Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Created attachment 165024 [details] [review] Bug 36490: Correct tab-switching keyboard shortcut for header search forms This patch updates staff-global.js so that we correctly define the keyboard shortcuts for search header tabs following the switch to using the WRAPPER for tabs in Bug 35850. To test, apply the patch clear your browser cache if necessary. - Go to the staff interface. - Test each keyboard shortcut to confirm that the header search tabs activate correctly: - Check in: Alt-r - Renew: Alt-w - Search: Alt-q - Check out: Alt-u - Test that the keyboard shortcut takes you to the correct page if the header search form doesn't exist on the page, e.g. the Authorities home page. Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
All working nicely, thanks Owen.
Pushed for 24.05! Well done everyone, thank you!
Depends on Bug 35850 not in 23.11.x
Bug fix. Nothing to change in the Koha manual. I added the Alt-W that was missing and updated the formatting. https://gitlab.com/koha-community/koha-manual/-/merge_requests/894