Bug 36510 - Add CircControl information to circulation and fine rules page
Summary: Add CircControl information to circulation and fine rules page
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Andrew Fuerste-Henry
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-03 20:53 UTC by hebah
Modified: 2024-09-27 14:12 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission: This patch adds text to the circulation rules interface that displays the values of the CircControl and HomeOrHoldingBranch system preferences. These values are useful to see within this page as they impact how the circulation rules will be enforced.
Text to go in the release notes:
Version(s) released in:
24.05.00
Circulation function:

Attachments
Bug 36510: Add CircControl and HomeOrHoldingBranch settings to smart-rules (1.69 KB, patch)
2024-04-04 21:30 UTC, Andrew Fuerste-Henry 		Details | Diff | Splinter Review
Bug 36510: Add CircControl and HomeOrHoldingBranch settings to smart-rules (1.75 KB, patch)
2024-04-04 22:01 UTC, ByWater Sandboxes 		Details | Diff | Splinter Review
Bug 36510: Add CircControl and HomeOrHoldingBranch settings to smart-rules (1.80 KB, patch)
2024-04-05 14:09 UTC, ByWater Sandboxes 		Details | Diff | Splinter Review
Bug 36510: Add CircControl and HomeOrHoldingBranch settings to smart-rules (1.85 KB, patch)
2024-04-23 13:15 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description hebah 2024-04-03 20:53:14 UTC 
It would be great to see, from the circulation rules, smart-rules.pl, what is set in CircControl. The pertinent preferences for holds and return policies appear in the default holds policy section, so it would be nice and increase transparency to see Circ Control setting near the circulation rule matrix and would make trouble-shooting circulation anomalies easier.
Comment 1 Lucy Vaux-Harvey 2024-04-04 08:47:48 UTC 
+1 - this would be a really nice addition
Comment 2 Andrew Fuerste-Henry 2024-04-04 21:30:04 UTC 
Created attachment 164439 [details] [review]
Bug 36510: Add CircControl and HomeOrHoldingBranch settings to smart-rules

To test:
1 - apply patch
2 - restart all
3 - load circ & fines rules, confirm syspref values show in the blue box of rules explanation
4 - change sysprefs and confirm values update on circ rules page
Comment 3 ByWater Sandboxes 2024-04-04 22:01:10 UTC 
Created attachment 164441 [details] [review]
Bug 36510: Add CircControl and HomeOrHoldingBranch settings to smart-rules

To test:
1 - apply patch
2 - restart all
3 - load circ & fines rules, confirm syspref values show in the blue box of rules explanation
4 - change sysprefs and confirm values update on circ rules page

Signed-off-by: Michelle Spinney <mspinney@clamsnet.org>
Comment 4 ByWater Sandboxes 2024-04-05 14:09:59 UTC 
Created attachment 164478 [details] [review]
Bug 36510: Add CircControl and HomeOrHoldingBranch settings to smart-rules

To test:
1 - apply patch
2 - restart all
3 - load circ & fines rules, confirm syspref values show in the blue box of rules explanation
4 - change sysprefs and confirm values update on circ rules page

Signed-off-by: Michelle Spinney <mspinney@clamsnet.org>
Signed-off-by: hebah <hebah@bywatersolutions.com>
Comment 5 Nick Clemens (kidclamp) 2024-04-23 13:15:30 UTC 
Created attachment 165394 [details] [review]
Bug 36510: Add CircControl and HomeOrHoldingBranch settings to smart-rules

To test:
1 - apply patch
2 - restart all
3 - load circ & fines rules, confirm syspref values show in the blue box of rules explanation
4 - change sysprefs and confirm values update on circ rules page

Signed-off-by: Michelle Spinney <mspinney@clamsnet.org>
Signed-off-by: hebah <hebah@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Katrin Fischer 2024-04-29 15:43:02 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-05-24 10:03:18 UTC 
Not backported to 23.11.x