Bug 36529 - manage_additional_fields permission for more than acquisitions and serials
Summary: manage_additional_fields permission for more than acquisitions and serials
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Caroline Cyr La Rose
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-04 21:04 UTC by Caroline Cyr La Rose
Modified: 2024-05-31 13:07 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06,23.05.12


Attachments
Bug 36529: manage_additional_fields permission for more than acquisitions and serials (1.94 KB, patch)
2024-04-12 10:00 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 36529: manage_additional_fields permission for more than acquisitions and serials (2.00 KB, patch)
2024-05-15 13:50 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 36529: manage_additional_fields permission for more than acquisitions and serials (2.05 KB, patch)
2024-05-15 14:16 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2024-04-04 21:04:58 UTC
More modules have been added to the additional fields (such as account lines).

The permission is titled

Manage additional fields for baskets or subscriptions (requires edit_subscription or order_manage permissions) (manage_additional_fields)

I think it should be changed to a more generic title.
Comment 1 Caroline Cyr La Rose 2024-04-12 10:00:31 UTC
Created attachment 164821 [details] [review]
Bug 36529: manage_additional_fields permission for more than acquisitions and serials

This patch renames the manage_additional_fields permission to remove
the specificity of acquisitions orders and serial subscriptions.
Since each additional field requires a corresponding permission, I
wrote each of them next to it. It makes it very long, but right now
there isn't really a way to link permissions other than the permission
description.

To test:
1. Apply patch
2. Go to a patron account
3. Click More > Set permissions
4. Go to the Administration panel permissions and open the
   sub-permissions
5. Check that the manage_additional_fields permission description
   makes sense, check grammar and spelling, try the various
   combinations
Comment 2 Pedro Amorim 2024-05-15 13:50:18 UTC
Created attachment 166777 [details] [review]
Bug 36529: manage_additional_fields permission for more than acquisitions and serials

This patch renames the manage_additional_fields permission to remove
the specificity of acquisitions orders and serial subscriptions.
Since each additional field requires a corresponding permission, I
wrote each of them next to it. It makes it very long, but right now
there isn't really a way to link permissions other than the permission
description.

To test:
1. Apply patch
2. Go to a patron account
3. Click More > Set permissions
4. Go to the Administration panel permissions and open the
   sub-permissions
5. Check that the manage_additional_fields permission description
   makes sense, check grammar and spelling, try the various
   combinations

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 3 Pedro Amorim 2024-05-15 13:54:32 UTC
I wonder if we should consider something more generic like:
"Manage additional fields for tables that support it (may require additional specific permissions for each table)"

The above wording could be improved but my point is that I can see this falling out of sync again in the future as new tables start adopting additional fields and this label is forgotten.
Just my 2 cents, definitely not a blocker.
Comment 4 Lucas Gass 2024-05-15 14:16:29 UTC
Created attachment 166781 [details] [review]
Bug 36529: manage_additional_fields permission for more than acquisitions and serials

This patch renames the manage_additional_fields permission to remove
the specificity of acquisitions orders and serial subscriptions.
Since each additional field requires a corresponding permission, I
wrote each of them next to it. It makes it very long, but right now
there isn't really a way to link permissions other than the permission
description.

To test:
1. Apply patch
2. Go to a patron account
3. Click More > Set permissions
4. Go to the Administration panel permissions and open the
   sub-permissions
5. Check that the manage_additional_fields permission description
   makes sense, check grammar and spelling, try the various
   combinations

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 5 Katrin Fischer 2024-05-17 08:28:09 UTC
Switching to a trivial bug - string change and it makes sense with the changed functionality.
Comment 6 Katrin Fischer 2024-05-17 08:37:32 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-05-29 13:22:36 UTC
Pushed to 23.11.x for 23.11.06
Comment 8 Lucas Gass 2024-05-31 13:07:18 UTC
Backported to 23.05.x for upcoming 23.05.12