Bug 33568 introduced a lot of new simple accessors without providing unit tests for them.
Created attachment 165080 [details] [review] Bug 36535: (bug 33568 follow-up) Add missing tests Bug 33568 introduced a lot of new simple accessors without providing unit tests for them. Test plan: All tests modified by this patch should pass Note that one bug was found! Logic issue in lost/not lost
Created attachment 165235 [details] [review] Bug 36535: (bug 33568 follow-up) Add missing tests Bug 33568 introduced a lot of new simple accessors without providing unit tests for them. Test plan: All tests modified by this patch should pass Note that one bug was found! Logic issue in lost/not lost Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. Tests pass both before and after: prove t/db_dependent/Items.t prove t/db_dependent/Koha/Biblio/ItemGroups.t prove t/db_dependent/Koha/Courses.t (new test) prove t/db_dependent/Koha/Item.t prove t/db_dependent/Koha/Items.t prove t/db_dependent/api/v1/biblios.t
Created attachment 165363 [details] [review] Bug 36535: (bug 33568 follow-up) Add missing tests Bug 33568 introduced a lot of new simple accessors without providing unit tests for them. Test plan: All tests modified by this patch should pass Note that one bug was found! Logic issue in lost/not lost Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 165364 [details] [review] Bug 36535: (QA follow-up) Use dt_from_string Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Great to see these tests coming through, thanks for the follow-up Jonathan! Passing QA
Pushed for 24.05! Well done everyone, thank you!
Depends on Bug 33568 not in 23.11.x