While looking at the set-library code I noticed a few things: -Currently you cannot set your desk/register if you are a superlibrarian. That is my fault due to Bug 36507. -There is an extra step after changing your branch/desk/register where you need to confirm, before being redirected. This is new behavior and unnecessary. We can make it better.
Created attachment 164665 [details] [review] Bug 36572: Fix and clean-up set library To test: 1. Have 3 staff accounts to test: -STAFF A: superlibrarian -STAFF B: loggedinlibrary permission -STAFF C: no loggedinlibrary or superlibrarian permission 2. Enable 'UseCirculationDesks' and create some desks. (Admin > Circulation desks) 3. Enable 'UseCashRegisters' and create some registers ( Admin > Cash registers) 4. Use STAFF A ( superlibrarian ) and make sure you can change branch, desk and register. 5. Use STAFF B ( loggedinlibrary permission ) and make sure you can change branch, desk and register. 6. Use STAFF C ( no loggedinlibrary or superlibrarian permission ) and make sure you can change branch, desk and register. 7. Each time you change you should be redirected to the page you were previously on.
Created attachment 164672 [details] [review] Bug 36572: Fix and clean-up set library To test: 1. Have 3 staff accounts to test: -STAFF A: superlibrarian -STAFF B: loggedinlibrary permission -STAFF C: no loggedinlibrary or superlibrarian permission 2. Enable 'UseCirculationDesks' and create some desks. (Admin > Circulation desks) 3. Enable 'UseCashRegisters' and create some registers ( Admin > Cash registers) 4. Use STAFF A ( superlibrarian ) and make sure you can change branch, desk and register. 5. Use STAFF B ( loggedinlibrary permission ) and make sure you can change branch, desk and register. 6. Use STAFF C ( no loggedinlibrary or superlibrarian permission ) and make sure you can change branch, desk and register. 7. Each time you change you should be redirected to the page you were previously on. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 164679 [details] [review] Bug 36572: (follow-up) More template clean-up Further testing: 1. Turn off UseCirculationDesks, make sure everything still works. 2. Turn off UseCashRegisters, make sure everthing still works.
Created attachment 164706 [details] [review] Bug 36572: Fix and clean-up set library To test: 1. Have 3 staff accounts to test: -STAFF A: superlibrarian -STAFF B: loggedinlibrary permission -STAFF C: no loggedinlibrary or superlibrarian permission 2. Enable 'UseCirculationDesks' and create some desks. (Admin > Circulation desks) 3. Enable 'UseCashRegisters' and create some registers ( Admin > Cash registers) 4. Use STAFF A ( superlibrarian ) and make sure you can change branch, desk and register. 5. Use STAFF B ( loggedinlibrary permission ) and make sure you can change branch, desk and register. 6. Use STAFF C ( no loggedinlibrary or superlibrarian permission ) and make sure you can change branch, desk and register. 7. Each time you change you should be redirected to the page you were previously on. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 164707 [details] [review] Bug 36572: (follow-up) More template clean-up Further testing: 1. Turn off UseCirculationDesks, make sure everything still works. 2. Turn off UseCashRegisters, make sure everthing still works. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed for 24.05! Well done everyone, thank you!
Depends on Bug 36507 not in 23.11.x