The checkouts table hangs if any of the checked-out items have public or nonpublic notes, and causes a console error: Uncaught ReferenceError: ymd is not defined ymd is defined in document ready - presumably this broke when the checkouts table got refactored into its own function.
Created attachment 164760 [details] [review] Bug 36581: Define ymd in scope for checkouts table Test plan: 1. Find or create an item with a public or nonpublic note (in KTD default data, items on biblionumber 12 have notes already) 2. Check the item out to a patron --> Checkouts table loading never completes --> Browser console shows: "Uncaught ReferenceError: ymd is not defined" 3. Apply patch and clear browser cache 4. Refresh the page --> Checkout table loads and console error is gone
Created attachment 164761 [details] [review] Bug 36581: Define ymd in scope for checkouts table Test plan: 1. Find or create an item with a public or nonpublic note (in KTD default data, items on biblionumber 12 have notes already) 2. Check the item out to a patron --> Checkouts table loading never completes --> Browser console shows: "Uncaught ReferenceError: ymd is not defined" 3. Apply patch and clear browser cache 4. Refresh the page --> Checkout table loads and console error is gone Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Trivial one-line patch - self-SO
Created attachment 164775 [details] [review] Bug 36581: Define ymd in scope for checkouts table Test plan: 1. Find or create an item with a public or nonpublic note (in KTD default data, items on biblionumber 12 have notes already) 2. Check the item out to a patron --> Checkouts table loading never completes --> Browser console shows: "Uncaught ReferenceError: ymd is not defined" 3. Apply patch and clear browser cache 4. Refresh the page --> Checkout table loads and console error is gone Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
I suspect this is from the CSRF, but we should test this in older versions or uncover the fault
(In reply to Nick Clemens from comment #5) > I suspect this is from the CSRF, but we should test this in older versions > or uncover the fault I think it's bug 35506. I'll test and confirm.
(In reply to Emily Lamancusa from comment #6) > (In reply to Nick Clemens from comment #5) > > I suspect this is from the CSRF, but we should test this in older versions > > or uncover the fault > > I think it's bug 35506. I'll test and confirm. Confirmed - I'll add it a dependency.
Pushed for 24.05! Well done everyone, thank you!
Depends on Bug 35506 not in 23.11.x