Bug 36589 - Advanced cataloging - restore the correct height of the clipboard
Summary: Advanced cataloging - restore the correct height of the clipboard
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Phil Ringnalda
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 27769
  Show dependency treegraph
 
Reported: 2024-04-12 09:03 UTC by Caroline Cyr La Rose
Modified: 2024-05-31 15:34 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06,23.05.12


Attachments
Bug 36589: Advanced cataloging - restore the correct height of the clipboard (1.20 KB, patch)
2024-05-16 21:05 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 36589: Advanced cataloging - restore the correct height of the clipboard (1.25 KB, patch)
2024-05-17 15:05 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 36589: Advanced cataloging - restore the correct height of the clipboard (1.30 KB, patch)
2024-05-24 12:40 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2024-04-12 09:03:51 UTC
I was updating the screenshots for the manual in the advanced editor section and noticed the clipboard is very small compared to before. I don't use the advanced cataloging editor, so I don't know if it's a need for the clipboard to be large or small, but just clicking around, I find it hard to use with it being so small.

See the "before" screenshot: https://koha-community.org/manual/23.05/en/html/_images/advancedcataloging.png

To get there:

1. Enable the EnableAdvancedCatalogingEditor syspref
2. Search the catalog for a record
3. Click Edit > Edit record
4. Toggle the editor to the advanced editor
5. Click on the content of a field and press Ctrl+C
   --> The field should be added to the clipboard section on the left side
6. Redo step 5 a couple of times
   --> All the fields are added to the clipboard section on the left side, but only 1.5ish lines are shown
Comment 1 Caroline Cyr La Rose 2024-04-12 09:05:59 UTC
I searched a bit in bugzilla and didn't find a bug that made the clipboard small, so I think it might be an unexpected side effect of the redesign or of another change...
Comment 2 Caroline Cyr La Rose 2024-04-12 09:14:59 UTC
Sorry, me again.

I normally test in Chrome, and I see 1.5ish lines in Chrome. But I just tried in Firefox and I find it worst. Only one line is shown in Firefox and there are no arrows to indicate that there actually are more than one line in the clipboard.

"Before" picture: https://koha-community.org/manual/23.05/en/html/_images/advancedcataloging.png

My current clipboard in Chrome, with 3 fields copied into the clipboard: https://snipboard.io/E1DTjA.jpg

My current clipboard in Firefox, with 3 fields copied into it: https://snipboard.io/dRFVOI.jpg

I use Ubuntu 22.04 with Chrome 123.0.6312.105 and Firefox is 124.0.1, if it's relevant.
Comment 3 Phil Ringnalda 2024-04-12 23:24:45 UTC
Chances are it has been that way since 21.05, from bug 21851 adding https://git.koha-community.org/Koha-community/Koha/src/commit/1ea4a11c2a88f7b23b482e071db48ae235beb42b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss#L240 though that might have only wound up applying after some other later change (or even after a browser change in how to deal with the combination of <select size="10" style="height: calc(1.5em + .75rem + 2px);"> which is what the HTML plus the CSS amount to).

As the attempt to fix it in bug 27769 by just removing .brief from the parent fieldset shows, it does need to have the width: 100% it gets from fieldset.brief select so it doesn't start out with no width and grow to the width of any line copied into it, but it needs to avoid that one-line height.
Comment 4 Phil Ringnalda 2024-05-16 21:05:06 UTC
Created attachment 166856 [details] [review]
Bug 36589: Advanced cataloging - restore the correct height of the clipboard

A simple direct fix for the height of the advanced editor's clipboard, which
is a <select size="10"> that's currently cut down to the height of one thick
line by CSS intended for non-multiple, non-sized selects with dropdown menus.

Test plan:
1. Set the pref EnableAdvancedCatalogingEditor to Enable
2. Cataloging -> Advanced editor
3. Note the Clipboard is a single line tall
4. Apply patch, shift+reload Advanced editor
5. Note the Clipboard is ten lines tall
Comment 5 Owen Leonard 2024-05-17 15:05:35 UTC
Created attachment 166911 [details] [review]
Bug 36589: Advanced cataloging - restore the correct height of the clipboard

A simple direct fix for the height of the advanced editor's clipboard,
which is a <select size="10"> that's currently cut down to the height of
one thick line by CSS intended for non-multiple, non-sized selects with
dropdown menus.

Test plan:
1. Set the pref EnableAdvancedCatalogingEditor to Enable
2. Cataloging -> Advanced editor
3. Note the Clipboard is a single line tall
4. Apply patch, shift+reload Advanced editor
5. Note the Clipboard is ten lines tall

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 6 Phil Ringnalda 2024-05-17 16:32:56 UTC
Filed bug 36897 to keep the next person to use a sized or multiple select in a sidebar from having to figure out the need to do this.
Comment 7 Nick Clemens (kidclamp) 2024-05-24 12:40:09 UTC
Created attachment 167165 [details] [review]
Bug 36589: Advanced cataloging - restore the correct height of the clipboard

A simple direct fix for the height of the advanced editor's clipboard,
which is a <select size="10"> that's currently cut down to the height of
one thick line by CSS intended for non-multiple, non-sized selects with
dropdown menus.

Test plan:
1. Set the pref EnableAdvancedCatalogingEditor to Enable
2. Cataloging -> Advanced editor
3. Note the Clipboard is a single line tall
4. Apply patch, shift+reload Advanced editor
5. Note the Clipboard is ten lines tall

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 8 Katrin Fischer 2024-05-24 13:40:13 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 9 Fridolin Somers 2024-05-30 08:12:30 UTC
Pushed to 23.11.x for 23.11.06
Comment 10 Lucas Gass 2024-05-31 15:34:05 UTC
Backported to 23.05.x for upcoming 23.05.12