Bug 36610 - Some improvements to OPAC print CSS
Summary: Some improvements to OPAC print CSS
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial
Assignee: Owen Leonard
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 35810
Blocks:
  Show dependency treegraph
 
Reported: 2024-04-16 15:58 UTC by Katrin Fischer
Modified: 2024-11-18 16:18 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Circulation function:


Attachments
Bug 36610: Some improvements to OPAC print CSS (9.94 KB, patch)
2024-04-17 15:52 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 36610: Some improvements to OPAC print CSS (10.01 KB, patch)
2024-04-18 10:11 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 36610: Some improvements to OPAC print CSS (10.08 KB, patch)
2024-05-15 06:44 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2024-04-16 15:58:56 UTC
This applies to the OPAC and new to the staff interface as well: If you are on a long page and scroll down, a "Back to top" arrow will appear on the right bottom screen. This is great, but it would be greater if it didn't show on print outs :)
Comment 1 Owen Leonard 2024-04-17 15:43:04 UTC
I'm expanding the scope of the bug because I threw in some other fixes too.
Comment 2 Owen Leonard 2024-04-17 15:52:03 UTC
Created attachment 165025 [details] [review]
Bug 36610: Some improvements to OPAC print CSS

This patch makes a few CSS and markup changes to improve the print view.

The markup changes use Bootstrap's ".d-print-none" class to hide
specific elements without creating an ID or class specifically for those
elements.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

- Log in to the OPAC
- Test the following user pages by viewing the print preview:
  - Summary
  - Holds history
  - Messaging
  - Lists
  - Suggestions
- The "Personal details" tab hasn't been improved for printing but it's
  a good page to view to confirm that the "Back to top" arrow is now
  hidden in the print view.
Comment 3 Matt Blenkinsop 2024-04-18 10:11:12 UTC
Created attachment 165062 [details] [review]
Bug 36610: Some improvements to OPAC print CSS

This patch makes a few CSS and markup changes to improve the print view.

The markup changes use Bootstrap's ".d-print-none" class to hide
specific elements without creating an ID or class specifically for those
elements.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

- Log in to the OPAC
- Test the following user pages by viewing the print preview:
  - Summary
  - Holds history
  - Messaging
  - Lists
  - Suggestions
- The "Personal details" tab hasn't been improved for printing but it's
  a good page to view to confirm that the "Back to top" arrow is now
  hidden in the print view.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2024-05-15 06:44:21 UTC
Created attachment 166748 [details] [review]
Bug 36610: Some improvements to OPAC print CSS

This patch makes a few CSS and markup changes to improve the print view.

The markup changes use Bootstrap's ".d-print-none" class to hide
specific elements without creating an ID or class specifically for those
elements.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

- Log in to the OPAC
- Test the following user pages by viewing the print preview:
  - Summary
  - Holds history
  - Messaging
  - Lists
  - Suggestions
- The "Personal details" tab hasn't been improved for printing but it's
  a good page to view to confirm that the "Back to top" arrow is now
  hidden in the print view.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Katrin Fischer 2024-05-17 08:37:35 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-05-29 13:20:11 UTC
Does not apply on 23.11.x
Maybe no need to backport.