Bug 36614 - Reinstate phone column in patron search
Summary: Reinstate phone column in patron search
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-16 19:41 UTC by Caroline Cyr La Rose
Modified: 2024-05-28 21:19 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06
Circulation function:


Attachments
Bug 36614: Restore 'phone' on the main patron search (1.96 KB, patch)
2024-04-17 10:35 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 36614: Restore 'phone' on the main patron search (1.95 KB, patch)
2024-04-17 14:21 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 36614: Restore 'phone' on the main patron search (2.02 KB, patch)
2024-04-17 14:48 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 36614: Restore 'phone' on the main patron search (2.08 KB, patch)
2024-05-01 17:16 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2024-04-16 19:41:15 UTC
When performing a patron search (either through Patrons or Check out), there is no way to see the patron's phone number. This functionality was added in bug 17353, but the table has changed since then from table_borrowers to memberresultst. memberresultst doesn't have a phone number column.

To get there:
1. From the staff interface's main page, search for a common partial name in the Check out search bar at the top of the page (e.g. mar) to get more than one result.
--> No phone number column
2. Click the 'Columns' button at the top of the table
--> No phone number option

This table is customizable in
Administration > Table settings > Patrons > Page: members > memberresults

Note that table_borrowers still exists, and still has the phone number option
Administration > Table settings > Circulation > Page: circulation > table_borrowers
From bug 30068, it seems it is the table in the holds patron search.
Comment 1 Jonathan Druart 2024-04-17 10:35:00 UTC
Created attachment 164991 [details] [review]
Bug 36614: Restore 'phone' on the main patron search

It disappeared at some point (history is tricky here, I didn't manage to
track down what happened, it's a mess)

This patch adds a phone column after the "name and address" one. It's
hidden by default.
Comment 2 Jonathan Druart 2024-04-17 10:35:35 UTC
Let me know what you think about this patch.

I am wondering if the phone shouldn't actually be in the "name and address" column.
Comment 3 Caroline Cyr La Rose 2024-04-17 13:37:26 UTC
(In reply to Jonathan Druart from comment #2)

> I am wondering if the phone shouldn't actually be in the "name and address"
> column.

I thought about that too, but I like the idea of being able to sort by phone number.

I tested and it works well, but in Administration > Table settings, the column is named memberresultst instead of phone.
Comment 4 Jonathan Druart 2024-04-17 14:21:15 UTC
Created attachment 165017 [details] [review]
Bug 36614: Restore 'phone' on the main patron search

It disappeared at some point (history is tricky here, I didn't manage to
track down what happened, it's a mess)

This patch adds a phone column after the "name and address" one. It's
hidden by default.
Comment 5 Jonathan Druart 2024-04-17 14:21:35 UTC
(In reply to Caroline Cyr La Rose from comment #3)
> I tested and it works well, but in Administration > Table settings, the
> column is named memberresultst instead of phone.

Oops, sorry!
Comment 6 Marie-Luce Laflamme 2024-04-17 14:35:36 UTC
I agree with Caroline, it would be a nice touch to sort patrons by their phone numbers.
Comment 7 Caroline Cyr La Rose 2024-04-17 14:48:08 UTC
Created attachment 165021 [details] [review]
Bug 36614: Restore 'phone' on the main patron search

It disappeared at some point (history is tricky here, I didn't manage to
track down what happened, it's a mess)

This patch adds a phone column after the "name and address" one. It's
hidden by default.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 8 Caroline Cyr La Rose 2024-04-17 14:48:31 UTC
Thanks Jonathan!
Comment 9 Nick Clemens (kidclamp) 2024-05-01 17:16:39 UTC
Created attachment 166021 [details] [review]
Bug 36614: Restore 'phone' on the main patron search

It disappeared at some point (history is tricky here, I didn't manage to
track down what happened, it's a mess)

This patch adds a phone column after the "name and address" one. It's
hidden by default.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 10 Katrin Fischer 2024-05-02 11:20:06 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 11 Fridolin Somers 2024-05-24 12:39:25 UTC
Pushed to 23.11.x for 23.11.06