In the new OPAC self checkout feature (from bug 30979), when a patron tries to check out an item that is on hold for another patron, the message says This item appears to be reserved for another patron, please return it to the desk. 'reserved' in this case should be 'on hold' https://wiki.koha-community.org/wiki/Terminology#R To recreate: 1. Place a hold for a patron 2. Enable OpacTrustedCheckout 3. Log into the OPAC as another patron 4. Click Self checkout at the top of the page 5. Paste the item's barcode in the text input 6. Click 'Submit'
I would also add a period at the end of the sentence.
Created attachment 164963 [details] [review] Bug 36615: Terminology: use 'on hold' instead of 'reserved' in OPAC self checkout This patch changes the term 'reserved' to 'on hold' in the OPAC self checkout feature. To test: 1. Apply patch 2. Place a hold for a patron 3. Enable OpacTrustedCheckout 4. Log into the OPAC as another patron 5. Click Self checkout at the top of the page 6. Paste the item's barcode in the text input 7. Click 'Submit' 8. Make sure the warning sentence is correct and there are no spelling errors
I did not add the period at the end as none of the messages had one. I can do another patch to add the periods to all the messages, if necessary.
Created attachment 164999 [details] [review] Bug 36615: Terminology: use 'on hold' instead of 'reserved' in OPAC self checkout This patch changes the term 'reserved' to 'on hold' in the OPAC self checkout feature. To test: 1. Apply patch 2. Place a hold for a patron 3. Enable OpacTrustedCheckout 4. Log into the OPAC as another patron 5. Click Self checkout at the top of the page 6. Paste the item's barcode in the text input 7. Click 'Submit' 8. Make sure the warning sentence is correct and there are no spelling errors Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 165226 [details] [review] Bug 36615: Terminology: use 'on hold' instead of 'reserved' in OPAC self checkout This patch changes the term 'reserved' to 'on hold' in the OPAC self checkout feature. To test: 1. Apply patch 2. Place a hold for a patron 3. Enable OpacTrustedCheckout 4. Log into the OPAC as another patron 5. Click Self checkout at the top of the page 6. Paste the item's barcode in the text input 7. Click 'Submit' 8. Make sure the warning sentence is correct and there are no spelling errors Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Nice catch, thanks Caroline! Passing QA
Pushed for 24.05! Well done everyone, thank you!
I prefer not to impact stable versions on OPAC text