Bug 36623 - Remove localhost reference from counter logs page
Summary: Remove localhost reference from counter logs page
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Matt Blenkinsop
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 36627
  Show dependency tree / graph
 
Reported: 2024-04-17 15:03 UTC by Matt Blenkinsop
Modified: 2024-05-28 19:38 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06
Circulation function:

Attachments
Bug 36623: Remove localhost reference (1.68 KB, patch)
2024-04-17 15:12 UTC, Matt Blenkinsop 		Details | Diff | Splinter Review
Bug 36623: Fix translation (1.29 KB, patch)
2024-04-18 14:39 UTC, Matt Blenkinsop 		Details | Diff | Splinter Review
Bug 36623:(follow-up) Fix cypress test (1.30 KB, patch)
2024-05-15 10:42 UTC, Matt Blenkinsop 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2024-04-17 15:03:28 UTC 
There is a reference to localhost on the counter logs page that shouldn't be there and needs removing
Comment 1 Matt Blenkinsop 2024-04-17 15:12:27 UTC 
Created attachment 165023 [details] [review]
Bug 36623: Remove localhost reference

This patch removes a reference to localhost from a url within ERM

Test plan:
This is quite hard to test without sushi credentials and is quite an easy fix. Check the patch diff to verify that the localhost reference has now been removed from the url
Comment 2 Martin Renvoize (ashimema) 2024-04-17 18:26:25 UTC 
Very obvious and clear correction. Going straight for a PQA here.
Comment 3 Katrin Fischer 2024-04-18 14:24:36 UTC 
I believe this highlights an untranslatable string (Borrowernumber):

? `<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=${row.borrowernumber}">Borrowernumber ${row.borrowernumber}</a>`

Please fix in a follow-up or on a separate new bug report.
Comment 4 Matt Blenkinsop 2024-04-18 14:29:52 UTC 
That is addressed in bug 36627 which embeds the patron and uses the patron name instead
Comment 5 Katrin Fischer 2024-04-18 14:36:30 UTC 
Can you please double check the file for other occurences? I think there is another: "Cronjob"
Comment 6 Matt Blenkinsop 2024-04-18 14:39:19 UTC 
Created attachment 165114 [details] [review]
Bug 36623: Fix translation
Comment 7 Katrin Fischer 2024-04-18 14:52:20 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 8 Katrin Fischer 2024-04-19 16:07:42 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 9 Matt Blenkinsop 2024-05-15 10:42:42 UTC 
Created attachment 166767 [details] [review]
Bug 36623:(follow-up) Fix cypress test
Comment 10 Tomás Cohen Arazi (tcohen) 2024-05-15 20:45:36 UTC 
Follow up pushed to main. Thanks!
Comment 11 Fridolin Somers 2024-05-23 13:34:43 UTC 
Pushed to 23.11.x for 23.11.06
Comment 12 Lucas Gass (lukeg) 2024-05-28 19:38:50 UTC 
Doesn't apply cleanly to 23.05.x, no backport.