Bug 36639 - CSRF: Fix deleting authority from authority detail page
Summary: CSRF: Fix deleting authority from authority detail page
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 36192
  Show dependency tree / graph
 
Reported: 2024-04-18 09:43 UTC by Marcel de Rooy
Modified: 2024-07-05 09:56 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Circulation function:

Attachments
Bug 36639: Fix delete on authorities detail (1.94 KB, patch)
2024-04-18 09:44 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 36639: Fix delete on authorities detail (1.98 KB, patch)
2024-04-23 09:40 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2024-04-18 09:43:13 UTC 
You can delete the authority from the authority search result list.
But you cannot delete it from its detail page anymore.

Seems to be introduced with the CSRF changes.
Comment 1 Marcel de Rooy 2024-04-18 09:44:30 UTC 
Created attachment 165058 [details] [review]
Bug 36639: Fix delete on authorities detail

Test plan:
Verify that you can delete an authority from detail page again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2024-04-18 09:45:47 UTC 
Trivial: self SO

Not sure about upping severity..
Comment 3 Jonathan Druart 2024-04-23 09:40:26 UTC 
Created attachment 165361 [details] [review]
Bug 36639: Fix delete on authorities detail

Test plan:
Verify that you can delete an authority from detail page again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Katrin Fischer 2024-04-26 06:53:55 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-05-23 15:01:05 UTC 
23.11.x not impacted
Comment 6 David Nind 2024-07-05 09:56:34 UTC 
Restores functionality. No changes to the manual required.