Bug 36673 - Limit search for used categories and item types to current library
Summary: Limit search for used categories and item types to current library
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens (kidclamp)
QA Contact: Testopia
URL:
Keywords:
Depends on: 36447
Blocks:
  Show dependency treegraph
 
Reported: 2024-04-22 18:12 UTC by Nick Clemens (kidclamp)
Modified: 2024-05-28 21:27 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06


Attachments
bug 36673: Filter used categories and item types to current branch (1.57 KB, patch)
2024-04-22 18:13 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
bug 36673: Filter used categories and item types to current branch (1.62 KB, patch)
2024-04-23 13:49 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 36673: Filter used categories and item types to current branch (1.75 KB, patch)
2024-05-03 11:32 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 36673: Filter used categories and item types to current branch (1.75 KB, patch)
2024-05-03 11:33 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2024-04-22 18:12:37 UTC
Bug 36447 limited the categories looped on the smart-rules page to those currently used - we can go a bit further and limit them to the current branch we are loading
Comment 1 Nick Clemens (kidclamp) 2024-04-22 18:13:49 UTC
Created attachment 165344 [details] [review]
bug 36673: Filter used categories and item types to current branch

To test:
1 - Define some circulation rules for default and specific branches
2 - Apply patch
3 - Confirm rules display as before
Comment 2 ByWater Sandboxes 2024-04-23 13:49:33 UTC
Created attachment 165401 [details] [review]
bug 36673: Filter used categories and item types to current branch

To test:
1 - Define some circulation rules for default and specific branches
2 - Apply patch
3 - Confirm rules display as before

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 3 Pedro Amorim 2024-05-03 11:32:27 UTC Comment hidden (obsolete)
Comment 4 Pedro Amorim 2024-05-03 11:33:33 UTC
Created attachment 166110 [details] [review]
Bug 36673: Filter used categories and item types to current branch

To test:
1 - Define some circulation rules for default and specific branches
2 - Apply patch
3 - Confirm rules display as before

PA amended:
- bug->Bug in commit title
- squashed tidy

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 5 Katrin Fischer 2024-05-03 14:04:05 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-05-24 13:01:35 UTC
Pushed to 23.11.x for 23.11.06
Comment 7 Lucas Gass 2024-05-28 21:27:50 UTC
Missing dependencies for 23.05.x, no backport.