Bug 33174 added a warning when cancelling multiple holds from request.pl, clearly indicating how many holds would be cancelled. The added div is empty when directly cancelling a single hold (by clicking the FA trash can icon next to it), so it makes sense to hide it in that case.
Created attachment 165580 [details] [review] Bug 36701: Adjust confirmation to hide empty div To test: 1. Place a hold on any bib record 2. Cancel the hold by clicking the trash can icon next to it --> Note that there is an empty red page section in the modal 3. Apply patch and refresh the page 4. Repeat steps 1-2 --> No empty red page section 5. Confirm that the test plan from bug 33174 still works
Thanks Emily! Previous experience has told me that the hidden attribute doesn't always work well with jQuery's show() and hide() methods. I think it might be better to use style="display:none;" here. What do you think?
Thanks for the tip, Lucas! That's good to know. I'll amend my patch.
Created attachment 165583 [details] [review] Bug 36701: Adjust confirmation to hide empty div To test: 1. Place a hold on any bib record 2. Cancel the hold by clicking the trash can icon next to it --> Note that there is an empty red page section in the modal 3. Apply patch and refresh the page 4. Repeat steps 1-2 --> No empty red page section 5. Confirm that the test plan from bug 33174 still works
Created attachment 165588 [details] [review] Bug 36701: Adjust confirmation to hide empty div To test: 1. Place a hold on any bib record 2. Cancel the hold by clicking the trash can icon next to it --> Note that there is an empty red page section in the modal 3. Apply patch and refresh the page 4. Repeat steps 1-2 --> No empty red page section 5. Confirm that the test plan from bug 33174 still works Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This looks good, fixes an obvious problem, QA scripts are happy. I feel good marking this one straight to PQA.
Thanks, Lucas! Did you mean to set this to PQA? (it's still at Signed Off)
(In reply to Emily Lamancusa from comment #7) > Thanks, Lucas! Did you mean to set this to PQA? (it's still at Signed Off) Thanks Emily, I did mean to set that to PQA. :)
Pushed for 24.05! Well done everyone, thank you!
Depends on Bug 33174 not in 23.11.x
Bug fix, nothing to add/edit in the Koha manual.