Bug 36707 - Links on itemnumbers in report should say "item" instead of "record"
Summary: Links on itemnumbers in report should say "item" instead of "record"
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-26 13:36 UTC by Magnus Enger
Modified: 2024-11-15 17:49 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 36707: Links on itemnumbers in report should say "item", not "record" (3.05 KB, patch)
2024-08-09 12:54 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 36707: Links on itemnumbers in report should say "item", not "record" (3.10 KB, patch)
2024-08-09 18:37 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 36707: Links on itemnumbers in report should say "item", not "record" (3.20 KB, patch)
2024-08-16 07:20 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Enger 2024-04-26 13:36:14 UTC
To reproduce: 

- Add a report like "SELECT itemnumber, biblionumber FROM items LIMIT 10"
- Run the report
- Check the data menu on the biblionumbers, it will say "Edit record" and "View record"
- Check the data menu on the itemnumbers, it will also say "Edit record" and "View record"

It would be better if the data menu for itemnumbers said "Edit item" and "View item".
Comment 1 Owen Leonard 2024-08-09 12:54:37 UTC
Created attachment 170185 [details] [review]
Bug 36707: Links on itemnumbers in report should say "item", not "record"

This patch changes the labels on SQL report result links so that the
term "item" is used for editing or viewing an item.

To test, apply the patch and go to Reports -> Saved reports

- If necessary, create a report which will return biblionumbers and
  itemnumbers, e.g.

  SELECT itemnumber, biblionumber FROM items LIMIT 20

- Save and run the report. In the results, test the menus which can be
  triggered by clicking a biblionumber or itemnumber.
  - A biblionumber's menu should have "Edit record" and "View record."
  - An itemnumber's menu should have "Edit item" and "View item."

Sponsored-by: Athens County Public Libraries
Comment 2 Roman Dolny 2024-08-09 18:37:56 UTC
Created attachment 170215 [details] [review]
Bug 36707: Links on itemnumbers in report should say "item", not "record"

This patch changes the labels on SQL report result links so that the
term "item" is used for editing or viewing an item.

To test, apply the patch and go to Reports -> Saved reports

- If necessary, create a report which will return biblionumbers and
  itemnumbers, e.g.

  SELECT itemnumber, biblionumber FROM items LIMIT 20

- Save and run the report. In the results, test the menus which can be
  triggered by clicking a biblionumber or itemnumber.
  - A biblionumber's menu should have "Edit record" and "View record."
  - An itemnumber's menu should have "Edit item" and "View item."

Sponsored-by: Athens County Public Libraries
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 Marcel de Rooy 2024-08-16 07:20:13 UTC
Created attachment 170431 [details] [review]
Bug 36707: Links on itemnumbers in report should say "item", not "record"

This patch changes the labels on SQL report result links so that the
term "item" is used for editing or viewing an item.

To test, apply the patch and go to Reports -> Saved reports

- If necessary, create a report which will return biblionumbers and
  itemnumbers, e.g.

  SELECT itemnumber, biblionumber FROM items LIMIT 20

- Save and run the report. In the results, test the menus which can be
  triggered by clicking a biblionumber or itemnumber.
  - A biblionumber's menu should have "Edit record" and "View record."
  - An itemnumber's menu should have "Edit item" and "View item."

Sponsored-by: Athens County Public Libraries
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2024-08-16 07:20:38 UTC
Moved to enh too
Comment 5 Katrin Fischer 2024-08-26 15:43:39 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Magnus Enger 2024-08-27 06:33:37 UTC
Thanks for fixing this! :-)