From https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122#c116 The script should have a --confirm flag
Created attachment 165807 [details] [review] Bug 36709: Add confirm flag to update_localuse_from_statistics.pl script To test: 1. APPLY PATCH and restart all 2. Run the update_localuse_from_statistics.pl script without a confirm flag, nothing happens. 3. Run the script and add the --confirm flag, stuff happens.
This is an addition to an already pushed new script - makes sense to have in 24.05!
Created attachment 165839 [details] [review] Bug 36709: Add confirm flag to update_localuse_from_statistics.pl script To test: 1. APPLY PATCH and restart all 2. Run the update_localuse_from_statistics.pl script without a confirm flag, nothing happens. 3. Run the script and add the --confirm flag, stuff happens. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 166244 [details] [review] Bug 36709: Add confirm flag to update_localuse_from_statistics.pl script To test: 1. APPLY PATCH and restart all 2. Run the update_localuse_from_statistics.pl script without a confirm flag, nothing happens. 3. Run the script and add the --confirm flag, stuff happens. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Simple addition here.. works as designed. Passing QA
Pushed for 24.05! Well done everyone, thank you!
Depends on Bug 16122 not in 23.11.x