When using the opac trusted checkout feature it is possible to enter non existant or partial barcodes to check out items. Testplan: a) set System preference OpacTrustedCheckout to Allow b) go to http://localhost:8080/ and login with koha / koha c) click Self Checkout in navigation bar d) enter barcode 1234 e) result is: Item '39999000011234' was checked out Expected behaviour: The selfcheck should show an error that barcode 1234 is not existing.
Created attachment 166118 [details] [review] Bug 36772: OPAC Self checkout accepts wrong or partial barcodes When using the opac trusted checkout feature it is possible to enter non existant or partial barcodes to check out items. Testplan: a) set System preference OpacTrustedCheckout to Allow b) go to http://localhost:8080/ and login with koha / koha c) click Self Checkout in navigation bar d) enter barcode 1234 e) result: Item '39999000011234' was checked out apply patch and reload the page a) now enter barcode 1234 b) result: Item '1234' not found c) enter 39999000011234 d) result: Item '39999000011234' was checked out
Created attachment 166119 [details] [review] Bug 36772: OPAC Self checkout accepts wrong or partial barcodes When using the opac trusted checkout feature it is possible to enter non existant or partial barcodes to check out items. Testplan: a) set System preference OpacTrustedCheckout to Allow b) go to http://localhost:8080/ and login with koha / koha c) click Self Checkout in navigation bar d) enter barcode 1234 e) result: Item '39999000011234' was checked out apply patch and reload the page a) now enter barcode 1234 b) result: Item '1234' not found c) enter 39999000011234 d) result: Item '39999000011234' was checked out Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 166629 [details] [review] Bug 36772: OPAC Self checkout accepts wrong or partial barcodes When using the opac trusted checkout feature it is possible to enter non existant or partial barcodes to check out items. Testplan: a) set System preference OpacTrustedCheckout to Allow b) go to http://localhost:8080/ and login with koha / koha c) click Self Checkout in navigation bar d) enter barcode 1234 e) result: Item '39999000011234' was checked out apply patch and reload the page a) now enter barcode 1234 b) result: Item '1234' not found c) enter 39999000011234 d) result: Item '39999000011234' was checked out Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Doh, this is a mistake on my part, thanks for the fix Jan. All works as intended now, Passing QA
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06