From jenkins: koha_1 | ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Column count doesn't match value count at row 1 at /kohadevbox/koha/C4/Installer.pm line 741
Created attachment 166204 [details] [review] Bug 36790: List table columns for 230600052 queries We must list the columns, or the db rev will fail when a new column is added. It happened here when 33478 added 'style' Also remove id and dates
Hi, I set all my environment to test this, but it is not applying. Please adjust dependencies if required. Thanks
Created attachment 166218 [details] [review] Bug 36790: List table columns for 230600052 queries We must list the columns, or the db rev will fail when a new column is added. It happened here when 33478 added 'style' Also remove id and dates
Sorry, I embedded non-related changes!
Created attachment 166220 [details] [review] Bug 36790: List table columns for 230600052 queries We must list the columns, or the db rev will fail when a new column is added. It happened here when 33478 added 'style' Also remove id and dates To test: 1. On current main, run: $ ktd --shell k$ perl /kohadevbox/misc4dev/run_tests.pl --koha-dir=. --run-db-upgrade-only => FAIL: Tests explode for DB query issues 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Added a dependency on bug 25159, as I had to add a follow-up there for this to actually work.
Created attachment 166221 [details] [review] Bug 36790: List table columns for 230600052 queries We must list the columns, or the db rev will fail when a new column is added. It happened here when 33478 added 'style' Also remove id and dates To test: 1. On current main, run: $ ktd --shell k$ perl /kohadevbox/misc4dev/run_tests.pl --koha-dir=. --run-db-upgrade-only => FAIL: Tests explode for DB query issues 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed for 24.05! Well done everyone, thank you!
Bug 25159 and Bug 33478 not in 23.11.x but maybe needs this fix ?
Pushed to 23.11.x for 23.11.06 (Joubu confirmed)
Not needed in 23.05.x, no backport.