Bug 36824 - Fix conversion of __VERSION__ in system preferences to use main rather than master
Summary: Fix conversion of __VERSION__ in system preferences to use main rather than m...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Phil Ringnalda
QA Contact: Tomás Cohen Arazi (tcohen)
URL:
Keywords: rel_24_05_candidate
Depends on:
Blocks:
 
Reported: 2024-05-09 23:17 UTC by Phil Ringnalda
Modified: 2024-05-30 16:28 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Circulation function:

Attachments
Bug 36824: Fix conversion of __VERSION__ in system preferences to use main rather than master (1.21 KB, patch)
2024-05-09 23:36 UTC, Phil Ringnalda 		Details | Diff | Splinter Review
Bug 36824: Fix conversion of __VERSION__ in system preferences to use main rather than master (1.27 KB, patch)
2024-05-10 00:05 UTC, Chris Cormack 		Details | Diff | Splinter Review
Bug 36824: Fix conversion of __VERSION__ in system preferences to use main rather than master (1.33 KB, patch)
2024-05-10 12:10 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Phil Ringnalda 2024-05-09 23:17:47 UTC 
The descriptions of EmailFieldPrecedence and PatronSelfModificationMandatoryField have links to schema.koha-community.org which insert the running version into the URL. For development versions, those need to be inserting /main/ rather than /master/.
Comment 1 Phil Ringnalda 2024-05-09 23:31:33 UTC 
Well, a few more than just those two, counting is hard. Luckily, if one works they all work.
Comment 2 Phil Ringnalda 2024-05-09 23:36:20 UTC 
Created attachment 166480 [details] [review]
Bug 36824: Fix conversion of __VERSION__ in system preferences to use main rather than master

Test plan:
1. Administration > search system preferences for the words database columns
2. Click the links to schema.koha-community.org, note that they 404 with
   /master/ in the URL
3. Apply patch, reset_all
4. Search again, click the links, note that they load successfully with /main/
Comment 3 Chris Cormack 2024-05-10 00:05:37 UTC 
Created attachment 166482 [details] [review]
Bug 36824: Fix conversion of __VERSION__ in system preferences to use main rather than master

Test plan:
1. Administration > search system preferences for the words database columns
2. Click the links to schema.koha-community.org, note that they 404 with
   /master/ in the URL
3. Apply patch, reset_all
4. Search again, click the links, note that they load successfully with /main/

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 4 Tomás Cohen Arazi (tcohen) 2024-05-10 12:10:52 UTC 
Created attachment 166533 [details] [review]
Bug 36824: Fix conversion of __VERSION__ in system preferences to use main rather than master

Test plan:
1. Administration > search system preferences for the words database columns
2. Click the links to schema.koha-community.org, note that they 404 with
   /master/ in the URL
3. Apply patch, reset_all
4. Search again, click the links, note that they load successfully with /main/

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Katrin Fischer 2024-05-10 12:21:23 UTC 
Thx for finding and fixing these, Phil!
Comment 6 Katrin Fischer 2024-05-10 13:20:29 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-05-29 08:43:09 UTC 
Not for 23.11.x
Comment 8 Aude Charillon 2024-05-30 16:28:54 UTC 
No update to the Koha Manual needed.