Bug 36825 - Cannot hide "Protected" field via BorrowerUnwantedField system preference
Summary: Cannot hide "Protected" field via BorrowerUnwantedField system preference
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Emmi Takkinen
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-10 05:29 UTC by Emmi Takkinen
Modified: 2024-05-30 19:39 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06


Attachments
Bug 36825: Hide "Protected" field via BorrowerUnwantedField syspref (5.14 KB, patch)
2024-05-10 05:38 UTC, Emmi Takkinen
Details | Diff | Splinter Review
Bug 36825: Hide "Protected" field via BorrowerUnwantedField syspref (5.20 KB, patch)
2024-05-10 15:56 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 36825: Hide "Protected" field via BorrowerUnwantedField syspref (5.25 KB, patch)
2024-05-13 22:39 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Emmi Takkinen 2024-05-10 05:29:56 UTC
Setting field "Protected" as hidden in patron entry/modification form via BorrowerUnwantedField syspref doesn't work. Form is missing condition "UNLESS noprotected"

To reproduce:
1. From BorrowerUnwantedField, check field "Protected" as hidden.
2. Either attempt to create a new patron or edit existing one. 
=> Note that "Protected" is still displayed in the form.
Comment 1 Emmi Takkinen 2024-05-10 05:38:14 UTC
Created attachment 166488 [details] [review]
Bug 36825: Hide "Protected" field via BorrowerUnwantedField syspref

Setting field "Protected" as hidden in patron entry/modification
form via BorrowerUnwantedField syspref doesn't work. Form is
missing condition "UNLESS noprotected".

To test:
1. From BorrowerUnwantedField, check field "Protected" as hidden.
2. Either attempt to create a new patron or modify existing one.
=> Note that "Protected" is still displayed in the form.
3. Apply this patch.
4. Navigate back to create/modify patron form.
=> Note that "Protected" is no longer displayed.
5. Uncheck field "Protected" from BorrowerUnwantedField.
=> Field should now be displayed in create/modify form.

Sponsored-by: Koha-Suomi Oy
Comment 2 Andrew Fuerste-Henry 2024-05-10 15:56:06 UTC
Created attachment 166586 [details] [review]
Bug 36825: Hide "Protected" field via BorrowerUnwantedField syspref

Setting field "Protected" as hidden in patron entry/modification
form via BorrowerUnwantedField syspref doesn't work. Form is
missing condition "UNLESS noprotected".

To test:
1. From BorrowerUnwantedField, check field "Protected" as hidden.
2. Either attempt to create a new patron or modify existing one.
=> Note that "Protected" is still displayed in the form.
3. Apply this patch.
4. Navigate back to create/modify patron form.
=> Note that "Protected" is no longer displayed.
5. Uncheck field "Protected" from BorrowerUnwantedField.
=> Field should now be displayed in create/modify form.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Comment 3 Lucas Gass 2024-05-13 22:39:08 UTC
Created attachment 166661 [details] [review]
Bug 36825: Hide "Protected" field via BorrowerUnwantedField syspref

Setting field "Protected" as hidden in patron entry/modification
form via BorrowerUnwantedField syspref doesn't work. Form is
missing condition "UNLESS noprotected".

To test:
1. From BorrowerUnwantedField, check field "Protected" as hidden.
2. Either attempt to create a new patron or modify existing one.
=> Note that "Protected" is still displayed in the form.
3. Apply this patch.
4. Navigate back to create/modify patron form.
=> Note that "Protected" is no longer displayed.
5. Uncheck field "Protected" from BorrowerUnwantedField.
=> Field should now be displayed in create/modify form.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Lucas Gass 2024-05-13 22:41:47 UTC
Passing QA here. Would be nice to make this field work with BorrowerMandatory also. I filed a bug:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36848
Comment 5 Katrin Fischer 2024-05-14 13:35:25 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-05-29 12:36:24 UTC
Pushed to 23.11.x for 23.11.06
Comment 7 Lucas Gass 2024-05-30 19:39:21 UTC
Not needed in 23.05.x.