Bug 36827 - Tabs in the ERM module have a gap above the tab content
Summary: Tabs in the ERM module have a gap above the tab content
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Matt Blenkinsop
QA Contact: Kyle M Hall (khall)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-10 13:12 UTC by Matt Blenkinsop
Modified: 2024-05-30 19:22 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06
Circulation function:

Attachments
Bug 36827: Fix tab formatting (1.73 KB, patch)
2024-05-10 13:15 UTC, Matt Blenkinsop 		Details | Diff | Splinter Review
Bug 36827: Fix tab formatting (1.77 KB, patch)
2024-05-10 13:20 UTC, Paul Derscheid 		Details | Diff | Splinter Review
Bug 36827: Fix tab formatting (1.83 KB, patch)
2024-05-10 17:59 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2024-05-10 13:12:43 UTC 
There is a gap between the tabs and the tab content in the reports section and the data providers section of the ERM Module
Comment 1 Matt Blenkinsop 2024-05-10 13:15:17 UTC 
Created attachment 166556 [details] [review]
Bug 36827: Fix tab formatting

This patch removes unwanted whitespace between the tabs and the tab content

Test plan:
1) Enable the ERM module and navigate to the eUsage > Reports sections
2) Observe the whitespace between the tabs and the content
3) Apply patch and run yarn build
4) Hard refresh the page, the whitespace should be gone
Comment 2 Paul Derscheid 2024-05-10 13:20:14 UTC 
Created attachment 166558 [details] [review]
Bug 36827: Fix tab formatting

This patch removes unwanted whitespace between the tabs and the tab content

Test plan:
1) Enable the ERM module and navigate to the eUsage > Reports sections
2) Observe the whitespace between the tabs and the content
3) Apply patch and run yarn build
4) Hard refresh the page, the whitespace should be gone

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 3 Kyle M Hall (khall) 2024-05-10 17:59:21 UTC 
Created attachment 166590 [details] [review]
Bug 36827: Fix tab formatting

This patch removes unwanted whitespace between the tabs and the tab content

Test plan:
1) Enable the ERM module and navigate to the eUsage > Reports sections
2) Observe the whitespace between the tabs and the content
3) Apply patch and run yarn build
4) Hard refresh the page, the whitespace should be gone

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Katrin Fischer 2024-05-13 12:02:43 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-05-29 12:19:00 UTC 
Pushed to 23.11.x for 23.11.06