Bug 36828 - Remove unnecessary code from UsageStatisticsReportsHome.vue
Summary: Remove unnecessary code from UsageStatisticsReportsHome.vue
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor (vote)
Assignee: Matt Blenkinsop
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-10 13:18 UTC by Matt Blenkinsop
Modified: 2024-05-30 19:21 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06


Attachments
Bug 36828: Remove commented out code (1.13 KB, patch)
2024-05-10 13:19 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 36828: Remove commented out code (1.17 KB, patch)
2024-05-10 13:29 UTC, Paul Derscheid
Details | Diff | Splinter Review
Bug 36828: Remove commented out code (1.22 KB, patch)
2024-05-10 17:56 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2024-05-10 13:18:19 UTC
There is commented out code in the file that isn't needed - this can be removed
Comment 1 Matt Blenkinsop 2024-05-10 13:19:44 UTC
Created attachment 166557 [details] [review]
Bug 36828: Remove commented out code

Test plan:
1) Look at the patch diff and observe that the commented out code has been removed
Comment 2 Paul Derscheid 2024-05-10 13:29:19 UTC
Created attachment 166559 [details] [review]
Bug 36828: Remove commented out code

Test plan:
1) Look at the patch diff and observe that the commented out code has been removed

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 3 Kyle M Hall 2024-05-10 17:56:14 UTC
Created attachment 166589 [details] [review]
Bug 36828: Remove commented out code

Test plan:
1) Look at the patch diff and observe that the commented out code has been removed

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Katrin Fischer 2024-05-13 12:02:46 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-05-29 12:18:19 UTC
Pushed to 23.11.x for 23.11.06