- On the login form, the form field IDs need to be updated to match the changed form fields in set-library.tt. Inclusion of desk_selection.js and register_selection.js need to be removed. - On the cash register statistics page, the form needs specific JS to deal with just the library-cash register selection changes.
Created attachment 166651 [details] [review] Bug 36844: Set library, desk, and cash register menu follow-ups This patch ties up a couple of loose ends which should have been included in Bug 36582. The patch includes fixes for the staff interface login page and the cash register statistics page. To test you should have multiple libraries, desks, and cash registers defined. You may need to enable the UseCirculationDesks and UseCashRegisters system preferences. - Apply the patch and log out of the staff interface. - On the login form, test that changing your selected library correctly affects the desk and cash register dropdowns: Only desks and registers for your selected library should appear. - Log in and confirm that your selections were submitted correctly. - Go to Reports, and under "Statistics wizards" choose "Cash register." - Confirm that changes to the "Transaction library" correctly change the available options in the "Cash register" dropdown, including the "All" option. Sponsored-By: Athens County Public Libraries
Created attachment 166657 [details] [review] Bug 36844: Set library, desk, and cash register menu follow-ups This patch ties up a couple of loose ends which should have been included in Bug 36582. The patch includes fixes for the staff interface login page and the cash register statistics page. To test you should have multiple libraries, desks, and cash registers defined. You may need to enable the UseCirculationDesks and UseCashRegisters system preferences. - Apply the patch and log out of the staff interface. - On the login form, test that changing your selected library correctly affects the desk and cash register dropdowns: Only desks and registers for your selected library should appear. - Log in and confirm that your selections were submitted correctly. - Go to Reports, and under "Statistics wizards" choose "Cash register." - Confirm that changes to the "Transaction library" correctly change the available options in the "Cash register" dropdown, including the "All" option. Sponsored-By: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 166662 [details] [review] Bug 36844: Set library, desk, and cash register menu follow-ups This patch ties up a couple of loose ends which should have been included in Bug 36582. The patch includes fixes for the staff interface login page and the cash register statistics page. To test you should have multiple libraries, desks, and cash registers defined. You may need to enable the UseCirculationDesks and UseCashRegisters system preferences. - Apply the patch and log out of the staff interface. - On the login form, test that changing your selected library correctly affects the desk and cash register dropdowns: Only desks and registers for your selected library should appear. - Log in and confirm that your selections were submitted correctly. - Go to Reports, and under "Statistics wizards" choose "Cash register." - Confirm that changes to the "Transaction library" correctly change the available options in the "Cash register" dropdown, including the "All" option. Sponsored-By: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com>
For the cash register statistics report, if there are no cash register for a library, I'm assuming that displaying --All-- is OK.
Created attachment 166665 [details] [review] Bug 36844: Set library, desk, and cash register menu follow-ups This patch ties up a couple of loose ends which should have been included in Bug 36582. The patch includes fixes for the staff interface login page and the cash register statistics page. To test you should have multiple libraries, desks, and cash registers defined. You may need to enable the UseCirculationDesks and UseCashRegisters system preferences. - Apply the patch and log out of the staff interface. - On the login form, test that changing your selected library correctly affects the desk and cash register dropdowns: Only desks and registers for your selected library should appear. - Log in and confirm that your selections were submitted correctly. - Go to Reports, and under "Statistics wizards" choose "Cash register." - Confirm that changes to the "Transaction library" correctly change the available options in the "Cash register" dropdown, including the "All" option. Sponsored-By: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 166666 [details] [review] Bug 36844: (QA follow-up): fix forgotten 'for' attr change It didn't match the <select> id.
Created attachment 166770 [details] [review] Bug 36844: Set library, desk, and cash register menu follow-ups This patch ties up a couple of loose ends which should have been included in Bug 36582. The patch includes fixes for the staff interface login page and the cash register statistics page. To test you should have multiple libraries, desks, and cash registers defined. You may need to enable the UseCirculationDesks and UseCashRegisters system preferences. - Apply the patch and log out of the staff interface. - On the login form, test that changing your selected library correctly affects the desk and cash register dropdowns: Only desks and registers for your selected library should appear. - Log in and confirm that your selections were submitted correctly. - Go to Reports, and under "Statistics wizards" choose "Cash register." - Confirm that changes to the "Transaction library" correctly change the available options in the "Cash register" dropdown, including the "All" option. Sponsored-By: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 166771 [details] [review] Bug 36844: (QA follow-up): fix forgotten 'for' attr change It didn't match the <select> id. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 166772 [details] [review] Bug 36844: (QA follow-up) Fix preselected options on set-library.pl I found that when switching from a branch with a default register to one without, the default register for the last branch was remaining selected (though disabled) When opening the page if no desk was set (choose 'My library' on initial login) the branch was default to 'No desk' rather than defaulting to the first desk of the current branch Remove a debugging line as well Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed for 24.05! Well done everyone, thank you!
Depends on Bug 36582 not in 23.11.x