Bug 36856 - New order from existing bibliographic record does not show MARC subfield name
Summary: New order from existing bibliographic record does not show MARC subfield name
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on: 19289
Blocks:
  Show dependency treegraph
 
Reported: 2024-05-14 09:30 UTC by Fridolin Somers
Modified: 2024-05-31 13:14 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06,23.05.12


Attachments
Bug 36856: Fix marc subfield name in new order from existing biblio (1.83 KB, patch)
2024-05-14 09:48 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 36856: Fix marc subfield name in new order from existing biblio (1.88 KB, patch)
2024-05-14 15:39 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 36856: Fix marc subfield name in new order from existing biblio (1.94 KB, patch)
2024-05-17 15:12 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2024-05-14 09:30:05 UTC
In form of the bibliographic details when adding an order 'From a new (empty) record' in a basket, the marc subfield name is not shown.
The template calls [% field.lib | html %] but this comes from Koha::UI::Form::Builder::Biblio generate_subfield_form() which gives 'marc_lib'.
Comment 1 Fridolin Somers 2024-05-14 09:45:31 UTC
(In reply to Fridolin Somers from comment #0)
> In form of the bibliographic details when adding an order 'From a new
> (empty) record' in a basket, the marc subfield name is not shown.
> The template calls [% field.lib | html %] but this comes from
> Koha::UI::Form::Builder::Biblio generate_subfield_form() which gives
> 'marc_lib'.

Oups => adding an order 'From an existing record'
Comment 2 Fridolin Somers 2024-05-14 09:48:26 UTC
Created attachment 166681 [details] [review]
Bug 36856: Fix marc subfield name in new order from existing biblio

In form of the bibliographic details when adding an order 'From an existing record' in a basket, the marc subfield name is not shown.
The template calls [% field.lib | html %] but this comes from Koha::UI::Form::Builder::Biblio generate_subfield_form() which gives 'marc_lib'.

Test plan:
1) Be sure to have an ACQ biblio framework
2) Enable system preference UseACQFrameworkForBiblioRecords
3) Go to an acquisition basket
4) Add a term in 'From an existing record' and submit
5) On first result click on 'Add order'
6) Look at 'Catalog details'
=> Without patch you only see subfield tag and letter : (123a)
=> With patch you also see subfield name : Name (123a)
Comment 3 Lucas Gass 2024-05-14 15:39:14 UTC
Created attachment 166692 [details] [review]
Bug 36856: Fix marc subfield name in new order from existing biblio

In form of the bibliographic details when adding an order 'From an existing record' in a basket, the marc subfield name is not shown.
The template calls [% field.lib | html %] but this comes from Koha::UI::Form::Builder::Biblio generate_subfield_form() which gives 'marc_lib'.

Test plan:
1) Be sure to have an ACQ biblio framework
2) Enable system preference UseACQFrameworkForBiblioRecords
3) Go to an acquisition basket
4) Add a term in 'From an existing record' and submit
5) On first result click on 'Add order'
6) Look at 'Catalog details'
=> Without patch you only see subfield tag and letter : (123a)
=> With patch you also see subfield name : Name (123a)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Pedro Amorim 2024-05-17 15:12:09 UTC
Created attachment 166913 [details] [review]
Bug 36856: Fix marc subfield name in new order from existing biblio

In form of the bibliographic details when adding an order 'From an existing record' in a basket, the marc subfield name is not shown.
The template calls [% field.lib | html %] but this comes from Koha::UI::Form::Builder::Biblio generate_subfield_form() which gives 'marc_lib'.

Test plan:
1) Be sure to have an ACQ biblio framework
2) Enable system preference UseACQFrameworkForBiblioRecords
3) Go to an acquisition basket
4) Add a term in 'From an existing record' and submit
5) On first result click on 'Add order'
6) Look at 'Catalog details'
=> Without patch you only see subfield tag and letter : (123a)
=> With patch you also see subfield name : Name (123a)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 5 Katrin Fischer 2024-05-21 11:29:13 UTC
No string change, small template change.
Comment 6 Katrin Fischer 2024-05-21 11:41:24 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-05-29 13:44:54 UTC
Pushed to 23.11.x for 23.11.06
Comment 8 Lucas Gass 2024-05-31 13:14:39 UTC
Backported to 23.05.x for upcoming 23.05.12