Spurious warning about undefined variables when processing sort order.
Created attachment 166807 [details] [review] Bug 36879: Spurious warning in QueryBuilder Test plan: With ElasticSearch enabled, * Perform a search using the default sort order (i.e. 'relevance'). * Verify that no warnings are generated in plack-intranet-error.log
I think this bug should have the "Needs Signoff" status (I think it was accidentally set as "Needs documenting"). However, I can't seem to change it 8-(... I tested it, but couldn't change the status that way either with a git bz attach -e 36879 HEAD Testing notes (using KTD): 1. Start up KTD with Elasticsearch: ktd --es8 up 2. Go to the staff interface and search the catalog - I searched for perl 3. Change the sort order on the results page from Relevance to Author(A-Z) 4. Change the sort order on the results page from Author (A-Z) to relevance 5. Note that you have these warnings in the /var/log/koha/kohadev/plack-intranet-error.log logfile: [2024/08/01 14:15:24] [WARN] Use of uninitialized value $f in hash element at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 72 5. [2024/08/01 14:15:24] [WARN] Use of uninitialized value $d in hash element at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 72 5. 6. Apply the patch. 7. Restart everything: restart_all 8. Repeat steps 2-4: Result: No warnings in the log file!
Created attachment 169964 [details] [review] Bug 36879: Spurious warning in QueryBuilder Test plan: With ElasticSearch enabled, * Perform a search using the default sort order (i.e. 'relevance'). * Verify that no warnings are generated in plack-intranet-error.log Signed-off-by: David Nind <david@davidnind.com>
I updated the status from "Needs documenting" to "Needs Signoff" by changing the status a few times: 1. RESOLVED FIXED 2. REOPENED 3. Needs Signoff (Thanks to the tips in the Community Chat from Katrin!)
Created attachment 169996 [details] [review] Bug 36879: Spurious warning in QueryBuilder Test plan: With ElasticSearch enabled, * Perform a search using the default sort order (i.e. 'relevance'). * Verify that no warnings are generated in plack-intranet-error.log Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Please don't forget to tidy your code. Amended patch.
(In reply to Katrin Fischer from comment #6) > Please don't forget to tidy your code. Amended patch. Why does my qa tools no longer pick that up ?
(In reply to Marcel de Rooy from comment #7) > (In reply to Katrin Fischer from comment #6) > > Please don't forget to tidy your code. Amended patch. > > Why does my qa tools no longer pick that up ? I am not sure, I reset my ktd yesterday, so it should all be current. It showed 3 untidy lines for me here and was OK after I perltidied the section.
Pushed for 24.11! Well done everyone, thank you!
*** Bug 37433 has been marked as a duplicate of this bug. ***
Backported to 24.05.x for upcoming 24.05.04
Pushed to 23.11.x for 23.11.09
Applied to 23.05.x for 23.05.15