Bug 36892 - Wrong label on filter-orders include
Summary: Wrong label on filter-orders include
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Thibaud Guillot
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-17 09:12 UTC by Thibaud Guillot
Modified: 2024-05-31 13:15 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06,23.05.12


Attachments
Bug 36892: Fix label for 'is_standing' input (1.25 KB, patch)
2024-05-17 09:16 UTC, Thibaud Guillot
Details | Diff | Splinter Review
Bug 36892: Fix label for 'is_standing' input (1.30 KB, patch)
2024-05-17 14:45 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 36892: Fix label for 'is_standing' input (1.36 KB, patch)
2024-05-17 15:06 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Thibaud Guillot 2024-05-17 09:12:35 UTC
Label for search_children_too is repeated twice.. the second must be "is_standing" for "Order status" <li>
Comment 1 Thibaud Guillot 2024-05-17 09:16:46 UTC
Created attachment 166876 [details] [review]
Bug 36892: Fix label for 'is_standing' input

Test plan:

1) Go to acqui/histsearch.pl and look for "search_children_too" with dev
   tools console.
2) On 'is_standing' input, the same label is used
3) Apply this patch and reload it
4) Now it's correct

Sponsored by: BibLibre
Comment 2 Owen Leonard 2024-05-17 14:45:05 UTC
Created attachment 166909 [details] [review]
Bug 36892: Fix label for 'is_standing' input

Test plan:

1) Go to acqui/histsearch.pl and look for "search_children_too" with
   dev tools console.
2) On 'is_standing' input, the same label is used
3) Apply this patch and reload it
4) Now it's correct

Sponsored by: BibLibre

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Pedro Amorim 2024-05-17 15:06:53 UTC
Created attachment 166912 [details] [review]
Bug 36892: Fix label for 'is_standing' input

Test plan:

1) Go to acqui/histsearch.pl and look for "search_children_too" with
   dev tools console.
2) On 'is_standing' input, the same label is used
3) Apply this patch and reload it
4) Now it's correct

Sponsored by: BibLibre

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 4 Katrin Fischer 2024-05-21 11:30:02 UTC
No string change, small template fix.
Comment 5 Katrin Fischer 2024-05-21 11:41:27 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-05-29 13:45:46 UTC
Pushed to 23.11.x for 23.11.06
Comment 7 Lucas Gass 2024-05-31 13:15:44 UTC
Backported to 23.05.x for upcoming 23.05.12