Bug 36895 - Background job links for KBART import are not working
Summary: Background job links for KBART import are not working
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial
Assignee: Matt Blenkinsop
QA Contact:
URL:
Keywords:
Depends on: 34788
Blocks: 36831
  Show dependency treegraph
 
Reported: 2024-05-17 13:46 UTC by Matt Blenkinsop
Modified: 2024-07-29 05:11 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the background job page link after importing a KBART file in the ERM module (E-resource management > eHoldings > Local > Title > Import from KBART file). Previously, it linked to the background jobs page - it now links to the background job page for the import.
Version(s) released in:
24.11.00,24.05.02
Circulation function:


Attachments
Bug 36895: Fix background job link (1.86 KB, patch)
2024-05-17 13:51 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 36895: Fix background job link (1.89 KB, patch)
2024-05-19 06:21 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2024-05-17 13:46:08 UTC
The message with the link to the job queued is not correctly applying the job id to the link so it just takes you to the background jobs page rather than the specific job
Comment 1 Matt Blenkinsop 2024-05-17 13:51:44 UTC
Created attachment 166908 [details] [review]
Bug 36895: Fix background job link

This patch fixes the missing job id in the links from the import KBART file page

Test plan:
1) Import a KBART file to get the message at the top of the screen.
2) The message should include a link on the text "see progress"
3) Click the link, it should just take you to the background jobs page
4) Apply patch
5) yarn build
6) Hard refresh the browser
7) Repeat steps 1-3
8) It should correctly take you to the background job
Comment 2 David Nind 2024-05-19 06:21:32 UTC
Created attachment 166922 [details] [review]
Bug 36895: Fix background job link

This patch fixes the missing job id in the links from the import KBART file page

Test plan:
1) Import a KBART file to get the message at the top of the screen.
2) The message should include a link on the text "see progress"
3) Click the link, it should just take you to the background jobs page
4) Apply patch
5) yarn build
6) Hard refresh the browser
7) Repeat steps 1-3
8) It should correctly take you to the background job

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-05-19 06:24:59 UTC
Testing notes (using KTD):

1. For step 1, following the steps in bug 34788#c55 (using sample TV file attached to the bug):
   1.1 Enable the ERM module
   1.2 Navigate to E-resource management > eHoldings > Local > Packages
   1.3 Create at least one package
   1.4 Navigate to E-resource management > eHoldings > Local > Titles
   1.5 There should be a button for "Import from KBART file"
   1.6 Click this button
   1.7 Select the package that you created from the dropdown and then choose your KBART file using the "Choose file" button (download 'Example TSV file' from the bug)
   1.8 Click Submit
Comment 4 Katrin Fischer 2024-06-27 13:34:01 UTC
Picked from QA queue for main.
Comment 5 Katrin Fischer 2024-06-27 15:26:39 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Lucas Gass 2024-07-19 15:45:08 UTC
Backported to 24.05.x for upcoming 24.05.02
Comment 7 Fridolin Somers 2024-07-22 09:59:39 UTC
Depends on Bug 34788 not in 23.11.x
Comment 8 David Nind 2024-07-29 05:11:06 UTC
No changes required to the manual - no screenshots, only mentions that the imported file is sent to the background jobs for processing.