Bug 36904 - ILL error when searching from table search input
Summary: ILL error when searching from table search input
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major
Assignee: Pedro Amorim
QA Contact: Tomás Cohen Arazi (tcohen)
URL:
Keywords:
: 36951 (view as bug list)
Depends on: 35093
Blocks: 37178
  Show dependency tree / graph
 
Reported: 2024-05-21 09:12 UTC by Pedro Amorim
Modified: 2024-06-25 08:10 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06
Circulation function:

Attachments
Bug 36904: Fix batch->ill_batch (1000 bytes, patch)
2024-05-21 09:14 UTC, Pedro Amorim 		Details | Diff | Splinter Review
Bug 36904: Fix batch->ill_batch (1.43 KB, patch)
2024-05-21 09:15 UTC, Pedro Amorim 		Details | Diff | Splinter Review
Bug 36904: Fix batch->ill_batch (1.48 KB, patch)
2024-05-21 22:44 UTC, David Nind 		Details | Diff | Splinter Review
Bug 36904: Fix batch->ill_batch (1.54 KB, patch)
2024-05-23 16:05 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2024-05-21 09:12:52 UTC 

    


    


      



        
          Comment 1
        

        
          Pedro Amorim

        

        
        

        
          2024-05-21 09:14:29 UTC
        

      






Created attachment 166953 [details] [review]
Bug 36904: Fix batch->ill_batch

This was missed when renaming follow-ups were added to bug 30719

    


    


      



        
          Comment 2
        

        
          Pedro Amorim

        

        
        

        
          2024-05-21 09:15:21 UTC
        

      






Created attachment 166954 [details] [review]
Bug 36904: Fix batch->ill_batch

This was missed when renaming follow-ups were added to bug 30719

1) Enable ILL, install FreeForm and checkout the current compatible branch with main
  bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
  cd /kohadevbox/koha/Koha/Illbackends/FreeForm
  git checkout reorganize_ILL
2) Visit ILL module:
  http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl
3) Type whatever search in the tiny 'Search' input box directly above the table
4) Notice you get an error. Apply patch. Repeat.

    


    


      



        
          Comment 3
        

        
          David Nind

        

        
        

        
          2024-05-21 22:44:47 UTC
        

      






Created attachment 166994 [details] [review]
Bug 36904: Fix batch->ill_batch

This was missed when renaming follow-ups were added to bug 30719

1) Enable ILL, install FreeForm and checkout the current compatible branch with main
  bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
  cd /kohadevbox/koha/Koha/Illbackends/FreeForm
  git checkout reorganize_ILL
2) Visit ILL module:
  http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl
3) Type whatever search in the tiny 'Search' input box directly above the table
4) Notice you get an error. Apply patch. Repeat.

Signed-off-by: David Nind <david@davidnind.com>

    


    


      



        
          Comment 4
        

        
          Tomás Cohen Arazi (tcohen)

        

        
        

        
          2024-05-23 16:03:45 UTC
        

      






*** Bug 36951 has been marked as a duplicate of this bug. ***

    


    


      



        
          Comment 5
        

        
          Tomás Cohen Arazi (tcohen)

        

        
        

        
          2024-05-23 16:05:21 UTC
        

      






Created attachment 167121 [details] [review]
Bug 36904: Fix batch->ill_batch

This was missed when renaming follow-ups were added to bug 30719

1) Enable ILL, install FreeForm and checkout the current compatible branch with main
  bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
  cd /kohadevbox/koha/Koha/Illbackends/FreeForm
  git checkout reorganize_ILL
2) Visit ILL module:
  http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl
3) Type whatever search in the tiny 'Search' input box directly above the table
4) Notice you get an error. Apply patch. Repeat.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

    


    


      



        
          Comment 6
        

        
          Katrin Fischer

        

        
        

        
          2024-05-23 16:15:45 UTC
        

      






Pushed for 24.05!

Well done everyone, thank you!

    


    


      



        
          Comment 7
        

        
          Fridolin Somers

        

        
        

        
          2024-05-30 08:10:17 UTC
        

      






Pushed to 23.11.x for 23.11.06

    


    


      



        
          Comment 8
        

        
          Lucas Gass (lukeg)

        

        
        

        
          2024-05-31 15:32:06 UTC
        

      






Missing dependencies for 23.05.x, no backport