Bug 36911 - Reindent circ-menu.inc
Summary: Reindent circ-menu.inc
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-21 16:36 UTC by Owen Leonard
Modified: 2024-07-23 04:22 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This updates the circ-menu.inc include file used for the left-hand sidebar menu on circulation pages (when the CircSidebar system preference). It reindents the file so that it has consistent indentation, and adds comments to highlight the markup structure. These changes have no visible effect on the pages.
Version(s) released in:
24.11.00,24.05.02
Circulation function:

Attachments
Bug 36911: Reindent circ-menu.inc (40.37 KB, patch)
2024-05-21 17:15 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 36911: (follow-up) Add markup comments (9.88 KB, patch)
2024-05-21 17:15 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 36911: Reindent circ-menu.inc (40.42 KB, patch)
2024-05-27 23:55 UTC, David Nind 		Details | Diff | Splinter Review
Bug 36911: (follow-up) Add markup comments (9.92 KB, patch)
2024-05-27 23:55 UTC, David Nind 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-05-21 16:36:04 UTC 
I would like to reformat circ-menu.inc so that it has consistent spacing and indentation.
Comment 1 Owen Leonard 2024-05-21 17:15:01 UTC 
Created attachment 166985 [details] [review]
Bug 36911: Reindent circ-menu.inc

This patch reindents the circ-menu include file so that it has
consistent indentation. These changes should have no visible effect on
the page.

To test, apply the patch and enable the 'CircSidebar' system
preference if necessary.

- View any circulation page, including the checkout page, to confirm
  that the left-hand sidebar menu is unchanged.
- Test with the 'patronimages' system preference both on and off.

Viewing the diff while ignoring whitespace changes should show only
places where a line break was added.
Comment 2 Owen Leonard 2024-05-21 17:15:03 UTC 
Created attachment 166986 [details] [review]
Bug 36911: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.
Comment 3 David Nind 2024-05-27 23:55:35 UTC 
Created attachment 167199 [details] [review]
Bug 36911: Reindent circ-menu.inc

This patch reindents the circ-menu include file so that it has
consistent indentation. These changes should have no visible effect on
the page.

To test, apply the patch and enable the 'CircSidebar' system
preference if necessary.

- View any circulation page, including the checkout page, to confirm
  that the left-hand sidebar menu is unchanged.
- Test with the 'patronimages' system preference both on and off.

Viewing the diff while ignoring whitespace changes should show only
places where a line break was added.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2024-05-27 23:55:37 UTC 
Created attachment 167200 [details] [review]
Bug 36911: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Katrin Fischer 2024-06-27 13:18:06 UTC 
Picking an easy one out of QA queue :)
Comment 6 Katrin Fischer 2024-06-27 15:26:47 UTC 
Pushed for 24.11!

Well done everyone, thank you!
Comment 7 Lucas Gass (lukeg) 2024-07-19 15:30:24 UTC 
Backported to 24.05.x for upcoming 24.05.02
Comment 8 Fridolin Somers 2024-07-22 09:52:53 UTC 
I prefer not to impact oldstable 23.11.x
Comment 9 David Nind 2024-07-23 04:22:57 UTC 
No changes to the manual are required - there are no changes to the UI or functionality.