Bug 36914 - DBIx::Class warning from shelves.pl
Summary: DBIx::Class warning from shelves.pl
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 28561
Blocks:
  Show dependency treegraph
 
Reported: 2024-05-22 07:34 UTC by Jonathan Druart
Modified: 2024-05-31 13:20 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06,23.05.12


Attachments
Bug 36914: Remove DBIC warning in shelves.pl (1.06 KB, patch)
2024-05-22 07:36 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 36914: Remove DBIC warning in shelves.pl (1.16 KB, patch)
2024-05-22 11:16 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-05-22 07:34:40 UTC
DBIx::Class::ResultSet::_construct_results(): Unable to properly collapse has_many results in iterator mode due to order criteria - performed an eager cursor slurp underneath. Consider
 using ->all() instead at /kohadevbox/koha/Koha/Objects.pm line 319
Comment 1 Jonathan Druart 2024-05-22 07:35:15 UTC
Exactly the same as bug 28561, but for virtualshelves/shelves.pl (vs opac/opac-shelves.pl)
Comment 2 Jonathan Druart 2024-05-22 07:36:39 UTC
Created attachment 167005 [details] [review]
Bug 36914: Remove DBIC warning in shelves.pl

Same fix as Bug 28561: Remove DBIC warning in opac-shelves
But for staff
Comment 3 Marcel de Rooy 2024-05-22 11:16:58 UTC
Created attachment 167021 [details] [review]
Bug 36914: Remove DBIC warning in shelves.pl

Same fix as Bug 28561: Remove DBIC warning in opac-shelves
But for staff

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2024-05-22 14:20:22 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-05-29 14:11:14 UTC
Pushed to 23.11.x for 23.11.06
Comment 6 Lucas Gass 2024-05-31 13:20:58 UTC
Backported to 23.05.x for upcoming 23.05.12