Bug 3693 - Display options for buttons when holds triggered
Summary: Display options for buttons when holds triggered
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: PC All
: PATCH-Sent (DO NOT USE) enhancement
Assignee: Jane Wagner
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-05 02:45 UTC by Jane Wagner
Modified: 2012-10-26 00:41 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:13:48 UTC


---- Reported by jwagner@ptfs.com 2009-10-05 14:45:50 ----

I've had requests from a couple of sites to hide one or two of the buttons that display when a hold is triggered at checkin (Confirm, Print Slip and Confirm, Ignore).  Rather than continue down the path of local screen changes, I've set up some sysprefs to control the display of each button, and modified returns.pl and returns.tmpl to obey them.



---- Additional Comments From jwagner@ptfs.com 2009-10-06 17:45:49 ----

Patch sent 10/6/09 -- new sysprefs are HoldButtonConfirm, HoldButtonPrintConfirm, HoldButtonIgnore.  The code doesn't require any of them to be on, but sites should use at least one of HoldButtonConfirm or HoldButtonPrintConfirm.



---- Additional Comments From jwagner@ptfs.com 2010-05-12 13:43:46 ----

The fix for this bug (in ptfs-harley) can also be pulled from the public git repository at http://github.com/Koha-PTFS, branch http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3693




--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:13 UTC  ---

This bug was previously known as _bug_ 3693 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3693

Unknown operating system Windows 2000. Setting to default OS "All".
Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was jwagner@ptfs.com.
The original assignee of this bug does not have
   an account here. Reassigning to the default assignee
   for the component, gmcharlt@gmail.com.
   Previous assignee was jwagner@ptfs.com.
Bug reassigned, setting status to "NEW".
   Previous status was "ASSIGNED".

Comment 1 Owen Leonard 2011-01-12 14:38:14 UTC
This sounds like a problem better solved by improving the markup to enable changes via CSS.
Comment 2 Paul Poulain 2011-03-22 13:05:51 UTC
patch available at: https://github.com/ptfs/Koha-PTFS

Side note: I agree with Owen comment = We have too many sysprefs, this problem can be addressed through CSS
Comment 3 Paul Poulain 2011-05-11 15:58:18 UTC
patch outside + better way to solve the problem, marking WONTFIX