Bug 36956 - ERM eUsage reports: only the first 20 data providers are listed when creating a new report
Summary: ERM eUsage reports: only the first 20 data providers are listed when creating...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Matt Blenkinsop
QA Contact: Pedro Amorim
URL:
Keywords: rel_23_11_candidate
Depends on:
Blocks:
 
Reported: 2024-05-24 12:08 UTC by Michaela Sieber
Modified: 2024-07-29 23:45 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the "Choose data provider" dropdown list when creating a usage report in ERM so that all providers are listed (ERM > eUsage > Reports > Create report). Before this, it was only listing the first 20 data providers.
Version(s) released in:
24.11.00,24.05.02,23.11.07
Circulation function:


Attachments
Bug 36956: Allow all providers to be displayed in reports (1.48 KB, patch)
2024-05-28 10:42 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 36956: Allow all providers to be displayed in reports (1.52 KB, patch)
2024-05-28 12:37 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 36956: Allow all providers to be displayed in reports (1.89 KB, patch)
2024-06-20 10:44 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Michaela Sieber 2024-05-24 12:08:00 UTC
to reproduce:

1.) Go to ERM module and make sure you have more than 21 data providers stored in your database.

2.) Go to eUsage / reports and create new report (cgi-bin/koha/erm/eusage/reports)

3.) Check that only the first 20 data providers are displayed in the drop down
Comment 1 Matt Blenkinsop 2024-05-28 10:42:46 UTC
Created attachment 167217 [details] [review]
Bug 36956: Allow all providers to be displayed in reports

This patch fixes an incorrect usage of the API which was only returning 20 results.

Test plan:
1) Go to ERM module and make sure you have more than 21 data providers stored in your database.
2) Go to eUsage / reports and create new report (cgi-bin/koha/erm/eusage/reports)
3) Check that only the first 20 data providers are displayed in the drop down
4) Apply patch
5) yarn build or reset_all to rebuild the javascript
6) Repeat steps 1-3, all providers should now be displayed
Comment 2 Biblibre Sandboxes 2024-05-28 12:37:12 UTC
Created attachment 167221 [details] [review]
Bug 36956: Allow all providers to be displayed in reports

This patch fixes an incorrect usage of the API which was only returning 20 results.

Test plan:
1) Go to ERM module and make sure you have more than 21 data providers stored in your database.
2) Go to eUsage / reports and create new report (cgi-bin/koha/erm/eusage/reports)
3) Check that only the first 20 data providers are displayed in the drop down
4) Apply patch
5) yarn build or reset_all to rebuild the javascript
6) Repeat steps 1-3, all providers should now be displayed

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 3 Pedro Amorim 2024-06-20 10:44:42 UTC
Created attachment 167933 [details] [review]
Bug 36956: Allow all providers to be displayed in reports

This patch fixes an incorrect usage of the API which was only returning 20 results.

Test plan:
1) Go to ERM module and make sure you have more than 20 data providers stored in your database.
1) (Optional) Run the following command (k-t-d) to create 21 data providers:
  perl -MKoha::Database -e '
      my $schema = Koha::Database->schema;

      $schema->resultset("ErmUsageDataProvider")->create({
          name => "name ".$_
      }) for (1..21)
  '
2) Go to eUsage / reports and create new report (cgi-bin/koha/erm/eusage/reports)
3) Check that only the first 20 data providers are displayed in the drop down
4) Apply patch
5) yarn build or reset_all to rebuild the javascript
6) Repeat steps 1-3, all providers should now be displayed

PA amended patch: Updated commit message test plan

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 4 Katrin Fischer 2024-06-21 12:26:00 UTC
Such a small change, such a big effect :)
Comment 5 Katrin Fischer 2024-06-21 13:04:18 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Pedro Amorim 2024-07-11 13:55:21 UTC
Adding backport release keywords, can we please add this to 24.05.x and 23.11.x.
Comment 7 Lucas Gass 2024-07-11 19:36:55 UTC
Backported to 24.05.x for upcoming 24.05.02
Comment 8 Fridolin Somers 2024-07-17 14:26:15 UTC
Pushed to 23.11.x for 23.11.07
Comment 9 wainuiwitikapark 2024-07-19 03:40:28 UTC
not backporting to 23.05.x unless requested
Comment 10 David Nind 2024-07-29 21:31:25 UTC
I have:
1. Added a release note.
2. Removed the rel_23_11_candidate keyword, as it was pushed for 23.11.07.
3. Updated the status to RESOLVED FIXED - not backported to 23.05, no changes to the ERM chapter of the manual are required.