Bug 37005 - Holdings table will not load when noItemTypeImages is set to 'Don't show'
Summary: Holdings table will not load when noItemTypeImages is set to 'Don't show'
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on: 33568
Blocks: 37004
  Show dependency treegraph
 
Reported: 2024-05-31 21:23 UTC by Lucas Gass
Modified: 2024-08-29 04:25 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes a problem with the holdings table not loading when the noItemTypeImages system preference is set to 'Don't show'.
Version(s) released in:
24.11.00,24.05.02
Circulation function:


Attachments
Bug 37005: Fix problem with item_type_description being undefined (1.58 KB, patch)
2024-05-31 21:31 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 37005: Fix problem with item_type_description being undefined (1.63 KB, patch)
2024-06-01 19:48 UTC, David Nind
Details | Diff | Splinter Review
Bug 37005: Fix problem with item_type_description being undefined (1.71 KB, patch)
2024-06-12 14:31 UTC, Matt Blenkinsop
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2024-05-31 21:23:44 UTC
To recreate:
1. Set noItemTypeImages to 'Don't show'
2. Find a record with items and notice the holdings table never loads. 



Uncaught ReferenceError: item_type_description is not defined
Comment 1 Lucas Gass 2024-05-31 21:31:53 UTC
Created attachment 167318 [details] [review]
Bug 37005: Fix problem with item_type_description being undefined

To test:
1. Set noItemTypeImages to 'Don't show'
2. Find a record with items and notice the holdings table never loads.
3. APPLY patch, maybe clear borwser cache too.
4. Try again, the holdings table should load.
Comment 2 David Nind 2024-06-01 19:48:34 UTC
Created attachment 167321 [details] [review]
Bug 37005: Fix problem with item_type_description being undefined

To test:
1. Set noItemTypeImages to 'Don't show'
2. Find a record with items and notice the holdings table never loads.
3. APPLY patch, maybe clear borwser cache too.
4. Try again, the holdings table should load.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Matt Blenkinsop 2024-06-12 14:31:04 UTC
Created attachment 167667 [details] [review]
Bug 37005: Fix problem with item_type_description being undefined

To test:
1. Set noItemTypeImages to 'Don't show'
2. Find a record with items and notice the holdings table never loads.
3. APPLY patch, maybe clear borwser cache too.
4. Try again, the holdings table should load.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 4 Martin Renvoize 2024-06-13 13:33:19 UTC
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 5 Lucas Gass 2024-07-11 20:02:58 UTC
Backported to 24.05.x for upcoming 24.05.02
Comment 6 Fridolin Somers 2024-07-17 14:29:04 UTC
Depends on Bug 33568 not in 23.11.x
Comment 7 David Nind 2024-07-17 18:37:29 UTC
Fixes an issues, no user interface changes. No changes to the manual required.