Bug 37026 - Switching tabs in the sco_main page ( Checkouts, Holds, Charges ) creates a JS error
Summary: Switching tabs in the sco_main page ( Checkouts, Holds, Charges ) creates a J...
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Self checkout (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass
QA Contact: Matt Blenkinsop
URL:
Keywords:
Depends on:
Blocks: 37027
  Show dependency treegraph
 
Reported: 2024-06-04 14:29 UTC by Lucas Gass
Modified: 2024-08-01 02:07 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes a JavaScript error (dataTables is not defined) when switching between the checkouts, holds, and charges tabs in the OPAC self-checkout system.
Version(s) released in:
24.11.00,24.05.02,23.11.07
Circulation function:


Attachments
Bug 37026: Fix JS error on sco-main.tt (1.21 KB, patch)
2024-06-04 14:30 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 37026: Fix JS error on sco-main.tt (1.25 KB, patch)
2024-06-04 16:24 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 37026: Fix JS error on sco-main.tt (1.33 KB, patch)
2024-06-05 16:03 UTC, Matt Blenkinsop
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2024-06-04 14:29:00 UTC
To recreate: 

1. Have a patron with some checkouts, holds, and charges that can login into the SCO module.
2. To go  sco-main.pl and login 
3. Try changing tabs and notice the console error:

 dataTables is not defined
Comment 1 Lucas Gass 2024-06-04 14:30:51 UTC
Created attachment 167396 [details] [review]
Bug 37026: Fix JS error on sco-main.tt

To test:
1. Have a patron with some checkouts, holds, and charges that can login into the SCO module.
2. To go  sco-main.pl and login
3. Try changing tabs and notice the console error:

 dataTables is not defined

 4. APPLY PATCH
 5. Try again, there should be no error.
 6. Make sure you can switch the tabs without any issues.
Comment 2 Sam Lau 2024-06-04 16:24:19 UTC
Created attachment 167406 [details] [review]
Bug 37026: Fix JS error on sco-main.tt

To test:
1. Have a patron with some checkouts, holds, and charges that can login into the SCO module.
2. To go  sco-main.pl and login
3. Try changing tabs and notice the console error:

 dataTables is not defined

 4. APPLY PATCH
 5. Try again, there should be no error.
 6. Make sure you can switch the tabs without any issues.

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Matt Blenkinsop 2024-06-05 16:03:50 UTC
Created attachment 167460 [details] [review]
Bug 37026: Fix JS error on sco-main.tt

To test:
1. Have a patron with some checkouts, holds, and charges that can login into the SCO module.
2. To go  sco-main.pl and login
3. Try changing tabs and notice the console error:

 dataTables is not defined

 4. APPLY PATCH
 5. Try again, there should be no error.
 6. Make sure you can switch the tabs without any issues.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 4 Martin Renvoize 2024-06-10 15:27:31 UTC
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 5 Lucas Gass 2024-07-17 13:57:34 UTC
Backported to 24.05.x for upcoming 24.05.02
Comment 6 Fridolin Somers 2024-07-17 14:02:07 UTC
Pushed to 23.11.x for 23.11.07
Comment 7 wainuiwitikapark 2024-07-19 03:28:47 UTC
not backporting to 23.05.x unless requested