Bug 37044 - OPAC message from SCO missing library branch
Summary: OPAC message from SCO missing library branch
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Self checkout (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Sam Lau
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-06 14:23 UTC by Sam Lau
Modified: 2024-07-22 10:02 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the self checkout "Messages for you" section for a patron so that any OPAC messages added by library staff now include the library name. Previously, "Written on DD/MM/YYYY by " was displayed after the message without including the library name.
Version(s) released in:
24.11.00,24.05.02,23.11.07
Circulation function:


Attachments
Bug 37044: Added library branch to SCO OPAC message (1.64 KB, patch)
2024-06-06 14:37 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 37044: Added library branch to SCO OPAC message (1.69 KB, patch)
2024-06-18 13:30 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Lau 2024-06-06 14:23:55 UTC
To recreate:

1) From the staff interface, click on a patron and add an OPAC message to their 
   account. 
2) Log into the SCO with this patron. 
   (http://localhost:8080/cgi-bin/koha/sco/sco-main.pl)
3) Notice how in the "Messages for you" at the top, you will see the message, 
   however, at the timestamp, it says something like "Written on 06/06/2024 by " 
   w/o listing the library that sent it.
Comment 1 Sam Lau 2024-06-06 14:37:28 UTC
Created attachment 167550 [details] [review]
Bug 37044: Added library branch to SCO OPAC message

This patch simply adds the correct branch at the end of an OPAC message on the SCO page.

To Test:
1) From the staff interface, click on a patron and add an OPAC message to their
   account.
2) Log into the SCO with this patron.
   (http://localhost:8080/cgi-bin/koha/sco/sco-main.pl)
3) Notice how in the "Messages for you" at the top, you will see the message,
   however, at the timestamp, it says something like "Written on 06/06/2024 by "
   w/o listing the library that sent it.
4) Apply patch
5) Log back into SCO module
6) Note that now in the message timestamp, it correctly lists the library that
   sent the message.
7) Sign-off
Comment 2 Owen Leonard 2024-06-18 13:30:58 UTC
Created attachment 167845 [details] [review]
Bug 37044: Added library branch to SCO OPAC message

This patch simply adds the correct branch at the end of an OPAC message on the SCO page.

To Test:
1) From the staff interface, click on a patron and add an OPAC message
   to their account.
2) Log into the SCO with this patron.
   (http://localhost:8080/cgi-bin/koha/sco/sco-main.pl)
3) Notice how in the "Messages for you" at the top, you will see the
   message, however, at the timestamp, it says something like "Written
   on 06/06/2024 by " w/o listing the library that sent it.
4) Apply patch
5) Log back into SCO module
6) Note that now in the message timestamp, it correctly lists the
   library that sent the message.
7) Sign-off

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Katrin Fischer 2024-06-27 15:18:48 UTC
Updated to bug fix.
Picked from QA queue for direct push to main.
Comment 4 Katrin Fischer 2024-06-27 15:27:02 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 5 Lucas Gass 2024-07-19 15:51:04 UTC
Backported to 24.05.x for upcoming 24.05.02
Comment 6 Fridolin Somers 2024-07-22 10:02:49 UTC
Pushed to 23.11.x for 23.11.07