To recreate: 1. Go to suggestions in the staff interface and enter a new suggestion. 2. Enter a title that matches something already in the catalog. In k-t-d I used "Lanark". 3. Submit the suggestion. 4. Get a blank page. What you should see is "A similar document already exists: Lanark. Click on "Confirm your suggestion" to ignore this message.".
Created attachment 168870 [details] [review] Bug 37337: Pass the save $op when biblio_exists To test: 1. Go to suggestions in the staff interface and enter a new suggestion. 2. Enter a title that matches something already in the catalog. In k-t-d I used "Lanark". 3. Submit the suggestion. 4. Get a blank page. 5. APPLY PATCH and restart_all 6. Now after step 3 you should get a page that shows the 'Click on "Confirm your suggestion" to ignore this message." warning, the form, and a Confirm your suggestion button.
Created attachment 168891 [details] [review] Bug 37337: Pass the save $op when biblio_exists To test: 1. Go to suggestions in the staff interface and enter a new suggestion. 2. Enter a title that matches something already in the catalog. In k-t-d I used "Lanark". 3. Submit the suggestion. 4. Get a blank page. 5. APPLY PATCH and restart_all 6. Now after step 3 you should get a page that shows the 'Click on "Confirm your suggestion" to ignore this message." warning, the form, and a Confirm your suggestion button. Signed-off-by: Jake Deery <jake.deery@ptfs-europe.com>
Created attachment 168892 [details] [review] Bug 37337: Pass the save $op when biblio_exists To test: 1. Go to suggestions in the staff interface and enter a new suggestion. 2. Enter a title that matches something already in the catalog. In k-t-d I used "Lanark". 3. Submit the suggestion. 4. Get a blank page. 5. APPLY PATCH and restart_all 6. Now after step 3 you should get a page that shows the 'Click on "Confirm your suggestion" to ignore this message." warning, the form, and a Confirm your suggestion button. Signed-off-by: Jan Kissig <jkissig@th-wildau.de>
Created attachment 168893 [details] [review] Bug 37337: Pass the save $op when biblio_exists To test: 1. Go to suggestions in the staff interface and enter a new suggestion. 2. Enter a title that matches something already in the catalog. In k-t-d I used "Lanark". 3. Submit the suggestion. 4. Get a blank page. 5. APPLY PATCH and restart_all 6. Now after step 3 you should get a page that shows the 'Click on "Confirm your suggestion" to ignore this message." warning, the form, and a Confirm your suggestion button. Signed-off-by: Jake Deery <jake.deery@ptfs-europe.com> Signed-off-by: Jan Kissig <jkissig@th-wildau.de>
Thanks, Lucas and Jan, Simple and effective, seems to do what it needs to do. Signed off with many thanks! Jake
Created attachment 169100 [details] [review] Bug 37337: Pass the save $op when biblio_exists To test: 1. Go to suggestions in the staff interface and enter a new suggestion. 2. Enter a title that matches something already in the catalog. In k-t-d I used "Lanark". 3. Submit the suggestion. 4. Get a blank page. 5. APPLY PATCH and restart_all 6. Now after step 3 you should get a page that shows the 'Click on "Confirm your suggestion" to ignore this message." warning, the form, and a Confirm your suggestion button. Signed-off-by: Jake Deery <jake.deery@ptfs-europe.com> Signed-off-by: Jan Kissig <jkissig@th-wildau.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial oversight, quick fix. Passing QA
Pushed for 24.11! Well done everyone, thank you!
Greetings - A gentle request and nudge to backport this to 24.05? Thanks!
Backported to 24.05.x for upcoming 24.05.04
Pushed to 23.11.x for 23.11.09
Not backporting to 23.05.x unless requested