Bug 37337 - Submitting a similar suggestion results in a blank page
Summary: Submitting a similar suggestion results in a blank page
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 14973
Blocks:
  Show dependency treegraph
 
Reported: 2024-07-11 22:03 UTC by Lucas Gass (lukeg)
Modified: 2024-09-18 06:47 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.04,23.11.09
Circulation function:


Attachments
Bug 37337: Pass the save $op when biblio_exists (1.08 KB, patch)
2024-07-11 22:14 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 37337: Pass the save $op when biblio_exists (1.15 KB, patch)
2024-07-12 11:10 UTC, Jake Deery
Details | Diff | Splinter Review
Bug 37337: Pass the save $op when biblio_exists (1.13 KB, patch)
2024-07-12 11:11 UTC, Jan Kissig
Details | Diff | Splinter Review
Bug 37337: Pass the save $op when biblio_exists (1.20 KB, patch)
2024-07-12 11:15 UTC, Jake Deery
Details | Diff | Splinter Review
Bug 37337: Pass the save $op when biblio_exists (1.25 KB, patch)
2024-07-17 16:14 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-07-11 22:03:52 UTC
To recreate:
1. Go to suggestions in the staff interface and enter a new suggestion.
2. Enter a title that matches something already in the catalog. In k-t-d I used "Lanark". 
3. Submit the suggestion. 
4. Get a blank page.

What you should see is "A similar document already exists: Lanark. Click on "Confirm your suggestion" to ignore this message.".
Comment 1 Lucas Gass (lukeg) 2024-07-11 22:14:43 UTC
Created attachment 168870 [details] [review]
Bug 37337: Pass the save $op when biblio_exists

To test:
1. Go to suggestions in the staff interface and enter a new suggestion.
2. Enter a title that matches something already in the catalog. In k-t-d I used "Lanark".
3. Submit the suggestion.
4. Get a blank page.
5. APPLY PATCH and restart_all
6. Now after step 3 you should get a page that shows the 'Click on "Confirm your suggestion" to ignore this message." warning, the form, and a Confirm your suggestion button.
Comment 2 Jake Deery 2024-07-12 11:10:55 UTC
Created attachment 168891 [details] [review]
Bug 37337: Pass the save $op when biblio_exists

To test:
1. Go to suggestions in the staff interface and enter a new suggestion.
2. Enter a title that matches something already in the catalog. In k-t-d I used "Lanark".
3. Submit the suggestion.
4. Get a blank page.
5. APPLY PATCH and restart_all
6. Now after step 3 you should get a page that shows the 'Click on "Confirm your suggestion" to ignore this message." warning, the form, and a Confirm your suggestion button.

Signed-off-by: Jake Deery <jake.deery@ptfs-europe.com>
Comment 3 Jan Kissig 2024-07-12 11:11:55 UTC
Created attachment 168892 [details] [review]
Bug 37337: Pass the save $op when biblio_exists

To test:
1. Go to suggestions in the staff interface and enter a new suggestion.
2. Enter a title that matches something already in the catalog. In k-t-d I used "Lanark".
3. Submit the suggestion.
4. Get a blank page.
5. APPLY PATCH and restart_all
6. Now after step 3 you should get a page that shows the 'Click on "Confirm your suggestion" to ignore this message." warning, the form, and a Confirm your suggestion button.

Signed-off-by: Jan Kissig <jkissig@th-wildau.de>
Comment 4 Jake Deery 2024-07-12 11:15:10 UTC
Created attachment 168893 [details] [review]
Bug 37337: Pass the save $op when biblio_exists

To test:
1. Go to suggestions in the staff interface and enter a new suggestion.
2. Enter a title that matches something already in the catalog. In k-t-d I used "Lanark".
3. Submit the suggestion.
4. Get a blank page.
5. APPLY PATCH and restart_all
6. Now after step 3 you should get a page that shows the 'Click on "Confirm your suggestion" to ignore this message." warning, the form, and a Confirm your suggestion button.

Signed-off-by: Jake Deery <jake.deery@ptfs-europe.com>
Signed-off-by: Jan Kissig <jkissig@th-wildau.de>
Comment 5 Jake Deery 2024-07-12 11:15:46 UTC
Thanks, Lucas and Jan,

Simple and effective, seems to do what it needs to do. Signed off with many thanks!

Jake
Comment 6 Martin Renvoize (ashimema) 2024-07-17 16:14:00 UTC
Created attachment 169100 [details] [review]
Bug 37337: Pass the save $op when biblio_exists

To test:
1. Go to suggestions in the staff interface and enter a new suggestion.
2. Enter a title that matches something already in the catalog. In k-t-d I used "Lanark".
3. Submit the suggestion.
4. Get a blank page.
5. APPLY PATCH and restart_all
6. Now after step 3 you should get a page that shows the 'Click on "Confirm your suggestion" to ignore this message." warning, the form, and a Confirm your suggestion button.

Signed-off-by: Jake Deery <jake.deery@ptfs-europe.com>
Signed-off-by: Jan Kissig <jkissig@th-wildau.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 7 Martin Renvoize (ashimema) 2024-07-17 16:15:15 UTC
Trivial oversight, quick fix.

Passing QA
Comment 8 Katrin Fischer 2024-07-18 15:57:30 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 9 CJ Lynce 2024-08-02 20:25:32 UTC
Greetings - A gentle request and nudge to backport this to 24.05? Thanks!
Comment 10 Lucas Gass (lukeg) 2024-09-06 16:30:21 UTC
Backported to 24.05.x for upcoming 24.05.04
Comment 11 Fridolin Somers 2024-09-17 13:55:30 UTC
Pushed to 23.11.x for 23.11.09
Comment 12 Wainui Witika-Park 2024-09-18 06:47:18 UTC
Not backporting to 23.05.x unless requested