To recreate: 1. Find an item to checkout and a patron to check out to. 2. Set a due manually: "Specify due date (MM/DD/YYYY):" 3. Before checking out click the "Remember for session:" checkbox. 4. Check the item out. 5. The specific due date is not retained.
Created attachment 168904 [details] [review] Bug 37345: Make stickyduedate stick To test: 1. Find an item to checkout and a patron to check out to. 2. Set a due manually: "Specify due date (MM/DD/YYYY):" 3. Before checking out click the "Remember for session:" checkbox. 4. Check the item out. 5. The specific due date is not retained. 6. APPLY PATCH 7. Try 1 -4 again, now the date should be sticking. 8. Turn on the OnSiteCheckouts system pref and make sure it still works 9. Turn on the OnSiteCheckoutAutoCheck system pref and make sure the on-site checkbox is still checked after doing an on-site checkout.
For step 7, it is now retaining a date - but not the original date I selected. Example: 1. Enter: - the barcode - expand the options for the field - enter or select 07/31/2024 - check the "Remember for session" tick box - click "Check out" 2. Note that the date is retained, however it is the current server system date (for me this was 07/14/2024, 23:59
Created attachment 169010 [details] [review] Bug 37345: Only toggle_onsite_checkout() if OnSiteCheckoutAutoCheck is enabled To test: 1. Find an item to checkout and a patron to check out to. 2. Set a due manually: "Specify due date (MM/DD/YYYY):" 3. Before checking out click the "Remember for session:" checkbox. 4. Check the item out. 5. The specific due date is not retained. 6. APPLY PATCH 7. Try 1 -4 again, now the date should be sticking. 8. Turn on the OnSiteCheckouts system pref and make sure it still works 9. Turn on the OnSiteCheckoutAutoCheck system pref and make sure the on-site checkbox is still checked after doing an on-site checkout.
Created attachment 169072 [details] [review] Bug 37345: Only toggle_onsite_checkout() if OnSiteCheckoutAutoCheck is enabled To test: 1. Find an item to checkout and a patron to check out to. 2. Set a due manually: "Specify due date (MM/DD/YYYY):" 3. Before checking out click the "Remember for session:" checkbox. 4. Check the item out. 5. The specific due date is not retained. 6. APPLY PATCH 7. Try 1 -4 again, now the date should be sticking. 8. Turn on the OnSiteCheckouts system pref and make sure it still works 9. Turn on the OnSiteCheckoutAutoCheck system pref and make sure the on-site checkbox is still checked after doing an on-site checkout. Signed-off-by: David Nind <david@davidnind.com>
I added my sign-off - now working as expected. Thanks Lucas!
Matt does a nice thorough job of setting remember options in bug 14787, worth a look ;)
Created attachment 169097 [details] [review] Bug 37345: Only toggle_onsite_checkout() if OnSiteCheckoutAutoCheck is enabled To test: 1. Find an item to checkout and a patron to check out to. 2. Set a due manually: "Specify due date (MM/DD/YYYY):" 3. Before checking out click the "Remember for session:" checkbox. 4. Check the item out. 5. The specific due date is not retained. 6. APPLY PATCH 7. Try 1 -4 again, now the date should be sticking. 8. Turn on the OnSiteCheckouts system pref and make sure it still works 9. Turn on the OnSiteCheckoutAutoCheck system pref and make sure the on-site checkbox is still checked after doing an on-site checkout. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
That said, this trivial bugfix is still important. PQA
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.02
Pushed to 23.11.x for 23.11.07
Not backporting to 23.05.x unless requested